Bug 32746 - Standardize structure around action fieldsets in acquisitions
Summary: Standardize structure around action fieldsets in acquisitions
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32743
Blocks: 32744 32771 32952 32954 32955 34452
  Show dependency treegraph
 
Reported: 2023-01-30 15:41 UTC by Owen Leonard
Modified: 2023-08-03 23:08 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32746: Standardize structure around action fieldsets in acquisitions (16.46 KB, patch)
2023-01-31 18:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32746: Standardize structure around action fieldsets in acquisitions (16.51 KB, patch)
2023-02-09 18:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 32746: Standardize structure around action fieldsets in acquisitions (16.56 KB, patch)
2023-02-24 16:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-30 15:41:04 UTC
As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers templates in acquisitions.
Comment 1 Owen Leonard 2023-01-31 18:08:52 UTC
Created attachment 145902 [details] [review]
Bug 32746: Standardize structure around action fieldsets in acquisitions

This patch updates acquisitions templates so that fieldsets with the
"action" class are placed outside the form's main fieldset. A couple of
minor changes have been made to related CSS.

To test, apply the patch and rebuild the staff interface CSS. Go to
acquisitions and check the following pages to confirm that changes to
form structure look correct:

- Open the "Late orders" page from the left-hand sidebar menu and check
  the form in the sidebar.
- Open the "Orders search" form in the search header and submit the form
  without specifying any search criteria. This should bring up a blank
  orders search form.
- Open the "Invoices" page from the left-hand sidebar menu. Check the
  form in the sidebar.
  - Perform an invoice search which will return results.
  - View one of the invoices returned by your search.
  - On the invoice detail age, the "Save" button associated with the
    invoice details at the top should look correct.
  - There should be a box below that with the heading "Adjustments" and
    a link to add an adjustment.
  - When you click "Add an adjustment," a form should be displayed with
    the correct controls at the bottom. Clicking "Cancel" should hide
    the form.
  - Click the "Manage invoice files" link, and check the form on that
    page.
- Locate a vendor and view its details.
  - Check the "Uncertain prices" page, linked from the menu in the
    left-hand sidebar.
  - Open the "Baskets" page from the left-hand sidebar. Click the "Add
    to basket" button for one of the existing baskets.
  - Click "From existing orders (copy)". Check that this form looks
    correct.
  - Open the "Basket groups" page from the left-hand sidebar menu.
    - Click "New basket group" and check that form.
Comment 2 David Nind 2023-02-07 21:58:14 UTC
The patch no longer applies - I'm getting a sha1 error:

git bz apply 32746

Bug 32746 - Standardize structure around action fieldsets in acquisitions

145902 - Bug 32746: Standardize structure around action fieldsets in acquisitions

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 32746: Standardize structure around action fieldsets in acquisitions
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 32746: Standardize structure around action fieldsets in acquisitions
Comment 3 Owen Leonard 2023-02-09 12:09:22 UTC
This is applying okay for me today, could you try again?
Comment 4 David Nind 2023-02-09 18:54:27 UTC
Created attachment 146447 [details] [review]
Bug 32746: Standardize structure around action fieldsets in acquisitions

This patch updates acquisitions templates so that fieldsets with the
"action" class are placed outside the form's main fieldset. A couple of
minor changes have been made to related CSS.

To test, apply the patch and rebuild the staff interface CSS. Go to
acquisitions and check the following pages to confirm that changes to
form structure look correct:

- Open the "Late orders" page from the left-hand sidebar menu and check
  the form in the sidebar.
- Open the "Orders search" form in the search header and submit the form
  without specifying any search criteria. This should bring up a blank
  orders search form.
- Open the "Invoices" page from the left-hand sidebar menu. Check the
  form in the sidebar.
  - Perform an invoice search which will return results.
  - View one of the invoices returned by your search.
  - On the invoice detail age, the "Save" button associated with the
    invoice details at the top should look correct.
  - There should be a box below that with the heading "Adjustments" and
    a link to add an adjustment.
  - When you click "Add an adjustment," a form should be displayed with
    the correct controls at the bottom. Clicking "Cancel" should hide
    the form.
  - Click the "Manage invoice files" link, and check the form on that
    page.
- Locate a vendor and view its details.
  - Check the "Uncertain prices" page, linked from the menu in the
    left-hand sidebar.
  - Open the "Baskets" page from the left-hand sidebar. Click the "Add
    to basket" button for one of the existing baskets.
  - Click "From existing orders (copy)". Check that this form looks
    correct.
  - Open the "Basket groups" page from the left-hand sidebar menu.
    - Click "New basket group" and check that form.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-02-09 18:55:07 UTC
(In reply to Owen Leonard from comment #3)
> This is applying okay for me today, could you try again?

Must have been something I did wrong at my end. Now applies, and have signed off.
Comment 6 Katrin Fischer 2023-02-24 16:34:42 UTC
Created attachment 147359 [details] [review]
Bug 32746: Standardize structure around action fieldsets in acquisitions

This patch updates acquisitions templates so that fieldsets with the
"action" class are placed outside the form's main fieldset. A couple of
minor changes have been made to related CSS.

To test, apply the patch and rebuild the staff interface CSS. Go to
acquisitions and check the following pages to confirm that changes to
form structure look correct:

- Open the "Late orders" page from the left-hand sidebar menu and check
  the form in the sidebar.
- Open the "Orders search" form in the search header and submit the form
  without specifying any search criteria. This should bring up a blank
  orders search form.
- Open the "Invoices" page from the left-hand sidebar menu. Check the
  form in the sidebar.
  - Perform an invoice search which will return results.
  - View one of the invoices returned by your search.
  - On the invoice detail age, the "Save" button associated with the
    invoice details at the top should look correct.
  - There should be a box below that with the heading "Adjustments" and
    a link to add an adjustment.
  - When you click "Add an adjustment," a form should be displayed with
    the correct controls at the bottom. Clicking "Cancel" should hide
    the form.
  - Click the "Manage invoice files" link, and check the form on that
    page.
- Locate a vendor and view its details.
  - Check the "Uncertain prices" page, linked from the menu in the
    left-hand sidebar.
  - Open the "Baskets" page from the left-hand sidebar. Click the "Add
    to basket" button for one of the existing baskets.
  - Click "From existing orders (copy)". Check that this form looks
    correct.
  - Open the "Basket groups" page from the left-hand sidebar menu.
    - Click "New basket group" and check that form.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 7 Tomás Cohen Arazi 2023-03-10 14:14:49 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-03-10 16:37:21 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Lucas Gass 2023-04-14 16:31:13 UTC
Missing dependencies for 22.05.x, no backport