Summary: | Add patron category to suggestion management tables | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | felicity.brown, gmcharlt, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 32774: Add patron category to suggestion managment tables
Bug 32774: Add patron category to suggestion managment tables Bug 32774: Add suggester category column to suggestion tables Bug 32774: Add suggester category column to suggestion tables Bug 32774: Add suggester category column to suggestion tables Bug 32774: (QA follow-up) Remove patron category type from display |
Description
Lucas Gass (lukeg)
2023-01-31 23:36:47 UTC
Created attachment 145917 [details] [review] Bug 32774: Add patron category to suggestion managment tables To test: 1. Apply patch 2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the 'Suggested by' column now included the patron category. 6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables. Created attachment 145927 [details] [review] Bug 32774: Add patron category to suggestion managment tables To test: 1. Apply patch 2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the 'Suggested by' column now included the patron category. 6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Having the patron type included in customer suggestions would be super helpful for our Acquisitions staff. It would be great if this were it's own separate column, so that purchase suggestions could be sorted by customer type (I'm thinking about sorting out staff requests for collection redevelopment versus new title suggestions from customers). (In reply to Felicity Brown from comment #3) > Having the patron type included in customer suggestions would be super > helpful for our Acquisitions staff. It would be great if this were it's own > separate column, so that purchase suggestions could be sorted by customer > type (I'm thinking about sorting out staff requests for collection > redevelopment versus new title suggestions from customers). Failing this based on Felicity's comment. New patch incoming. Created attachment 145967 [details] [review] Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. Created attachment 145975 [details] [review] Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> I believe that Felicity meant the patron category by 'customer's type'. So instead of 'Staff (S)', we should display the usual 'Staff' without the added type. I'll provide a patch to remove the patron category's type from display for consistency and because those single letters don't work well with translations and have been causing a lot of confusion in the past. Created attachment 146197 [details] [review] Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 146198 [details] [review] Bug 32774: (QA follow-up) Remove patron category type from display This is for consistency and because those single letters don't translate well and are more prone to cause confusion than being helpful. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Correct. The full word "Staff" is much more helpful than the abbreviation. (In reply to Felicity Brown from comment #10) > Correct. The full word "Staff" is much more helpful than the abbreviation. Thx Felicity! The full description will display. Please rebase. It colllides with bug 32603 This is a duplicate of 32603. *** This bug has been marked as a duplicate of bug 32603 *** |