Bug 32774

Summary: Add patron category to suggestion management tables
Product: Koha Reporter: Lucas Gass <lucas>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: felicity.brown, gmcharlt, kyle.m.hall, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 32774: Add patron category to suggestion managment tables
Bug 32774: Add patron category to suggestion managment tables
Bug 32774: Add suggester category column to suggestion tables
Bug 32774: Add suggester category column to suggestion tables
Bug 32774: Add suggester category column to suggestion tables
Bug 32774: (QA follow-up) Remove patron category type from display

Description Lucas Gass 2023-01-31 23:36:47 UTC
Some librarians would find it useful if the suggestion management tables on suggestion.tt included some information about the patron type in the Suggested by column. 

This could help staff make rapid decisions regarding suggestions based on the patron type.
Comment 1 Lucas Gass 2023-01-31 23:43:48 UTC
Created attachment 145917 [details] [review]
Bug 32774: Add patron category to suggestion managment tables

To test:
1. Apply patch
2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Make some suggestions
4. Go to  Acquisitions > Suggestions management
5. Notice the 'Suggested by' column now included the patron category.
6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables.
Comment 2 Matt Blenkinsop 2023-02-01 10:27:04 UTC
Created attachment 145927 [details] [review]
Bug 32774: Add patron category to suggestion managment tables

To test:
1. Apply patch
2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Make some suggestions
4. Go to  Acquisitions > Suggestions management
5. Notice the 'Suggested by' column now included the patron category.
6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 3 Felicity Brown 2023-02-01 15:31:04 UTC
Having the patron type included in customer suggestions would be super helpful for our Acquisitions staff. It would be great if this were it's own separate column, so that purchase suggestions could be sorted by customer type (I'm thinking about sorting out staff requests for collection redevelopment versus new title suggestions from customers).
Comment 4 Lucas Gass 2023-02-01 15:34:18 UTC
(In reply to Felicity Brown from comment #3)
> Having the patron type included in customer suggestions would be super
> helpful for our Acquisitions staff. It would be great if this were it's own
> separate column, so that purchase suggestions could be sorted by customer
> type (I'm thinking about sorting out staff requests for collection
> redevelopment versus new title suggestions from customers).

Failing this based on Felicity's comment. New patch incoming.
Comment 5 Lucas Gass 2023-02-01 16:55:14 UTC
Created attachment 145967 [details] [review]
Bug 32774: Add suggester category column to suggestion tables

To test:
1. Apply patch
2. Restart_all
3. Make some suggestions
4. Go to  Acquisitions > Suggestions management
5. Notice the new 'Suggester category' column which included the patron category of the suggester.
6. Put some suggestions in different statuses and make sure you see the new column on each of the tables.
7. Go to Table settings and make sure you can properly hide the new column and any other column in the table.
Comment 6 Matt Blenkinsop 2023-02-01 17:53:46 UTC
Created attachment 145975 [details] [review]
Bug 32774: Add suggester category column to suggestion tables

To test:
1. Apply patch
2. Restart_all
3. Make some suggestions
4. Go to  Acquisitions > Suggestions management
5. Notice the new 'Suggester category' column which included the patron category of the suggester.
6. Put some suggestions in different statuses and make sure you see the new column on each of the tables.
7. Go to Table settings and make sure you can properly hide the new column and any other column in the table.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 7 Katrin Fischer 2023-02-05 12:26:12 UTC
I believe that Felicity meant the patron category by 'customer's type'. So instead of 'Staff (S)', we should display the usual 'Staff' without the added type.

I'll provide a patch to remove the patron category's type from display for consistency and because those single letters don't work well with translations and have been causing a lot of confusion in the past.
Comment 8 Katrin Fischer 2023-02-05 12:28:42 UTC
Created attachment 146197 [details] [review]
Bug 32774: Add suggester category column to suggestion tables

To test:
1. Apply patch
2. Restart_all
3. Make some suggestions
4. Go to  Acquisitions > Suggestions management
5. Notice the new 'Suggester category' column which included the patron category of the suggester.
6. Put some suggestions in different statuses and make sure you see the new column on each of the tables.
7. Go to Table settings and make sure you can properly hide the new column and any other column in the table.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2023-02-05 12:28:46 UTC
Created attachment 146198 [details] [review]
Bug 32774: (QA follow-up) Remove patron category type from display

This is for consistency and because those single letters
don't translate well and are more prone to cause confusion
than being helpful.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Felicity Brown 2023-02-06 14:12:48 UTC
Correct. The full word "Staff" is much more helpful than the abbreviation.
Comment 11 Katrin Fischer 2023-02-06 18:00:55 UTC
(In reply to Felicity Brown from comment #10)
> Correct. The full word "Staff" is much more helpful than the abbreviation.

Thx Felicity! The full description will display.
Comment 12 Tomás Cohen Arazi 2023-02-07 18:35:13 UTC
Please rebase. It colllides with bug 32603
Comment 13 Lucas Gass 2023-02-07 18:50:54 UTC
This is a duplicate of 32603.

*** This bug has been marked as a duplicate of bug 32603 ***