Summary: | Import from list is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | ERM | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | major | ||
Priority: | P5 - low | CC: | jonathan.druart, jonathan.field, lucas, martin.renvoize, pedro.amorim, tomascohen |
Version: | unspecified | Keywords: | rel_22_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Bug Depends on: | 32030 | ||
Bug Blocks: | 30943 | ||
Attachments: |
Bug 32779: Add tests
Bug 32779: ERM - Fix import from list Bug 32779: Add tests Bug 32779: ERM - Fix import from list Bug 32779: Add tests Bug 32779: ERM - Fix import from list |
Description
Jonathan Druart
2023-02-01 13:05:33 UTC
Created attachment 145948 [details] [review] Bug 32779: Add tests Created attachment 145949 [details] [review] Bug 32779: ERM - Fix import from list There is a typo, '$' is missing, which caused the following error: Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 Test plan: Create a list, add an item Turn on ERM Create a package Go to /cgi-bin/koha/erm/eholdings/local/titles Click "Import from list" Select the package, then your list, and import It should succeed Created attachment 145968 [details] [review] Bug 32779: Add tests Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 145969 [details] [review] Bug 32779: ERM - Fix import from list There is a typo, '$' is missing, which caused the following error: Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 Test plan: Create a list, add an item Turn on ERM Create a package Go to /cgi-bin/koha/erm/eholdings/local/titles Click "Import from list" Select the package, then your list, and import It should succeed Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 145970 [details] [review] Bug 32779: Add tests Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 145971 [details] [review] Bug 32779: ERM - Fix import from list There is a typo, '$' is missing, which caused the following error: Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126 Test plan: Create a list, add an item Turn on ERM Create a package Go to /cgi-bin/koha/erm/eholdings/local/titles Click "Import from list" Select the package, then your list, and import It should succeed Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Fixes the described issue. No QA script complaints. Thanks Jonathan. Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Not needed in 22.05.x |