Bug 32779 - Import from list is broken
Summary: Import from list is broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi
URL:
Keywords: rel_22_11_candidate
Depends on: 32030
Blocks: 30943
  Show dependency treegraph
 
Reported: 2023-02-01 13:05 UTC by Jonathan Druart
Modified: 2023-12-28 20:43 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32779: Add tests (2.95 KB, patch)
2023-02-01 14:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32779: ERM - Fix import from list (1.59 KB, patch)
2023-02-01 14:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32779: Add tests (3.00 KB, patch)
2023-02-01 16:58 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32779: ERM - Fix import from list (1.65 KB, patch)
2023-02-01 16:58 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32779: Add tests (3.06 KB, patch)
2023-02-01 17:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 32779: ERM - Fix import from list (1.70 KB, patch)
2023-02-01 17:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-02-01 13:05:33 UTC
Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126
Comment 1 Jonathan Druart 2023-02-01 14:19:08 UTC
Created attachment 145948 [details] [review]
Bug 32779: Add tests
Comment 2 Jonathan Druart 2023-02-01 14:19:13 UTC
Created attachment 145949 [details] [review]
Bug 32779: ERM - Fix import from list

There is a typo, '$' is missing, which caused the following error:
Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126

Test plan:
Create a list, add an item
Turn on ERM
Create a package
Go to /cgi-bin/koha/erm/eholdings/local/titles
Click "Import from list"
Select the package, then your list, and import
It should succeed
Comment 3 Pedro Amorim 2023-02-01 16:58:44 UTC
Created attachment 145968 [details] [review]
Bug 32779: Add tests

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Pedro Amorim 2023-02-01 16:58:48 UTC
Created attachment 145969 [details] [review]
Bug 32779: ERM - Fix import from list

There is a typo, '$' is missing, which caused the following error:
Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126

Test plan:
Create a list, add an item
Turn on ERM
Create a package
Go to /cgi-bin/koha/erm/eholdings/local/titles
Click "Import from list"
Select the package, then your list, and import
It should succeed

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Tomás Cohen Arazi 2023-02-01 17:29:19 UTC
Created attachment 145970 [details] [review]
Bug 32779: Add tests

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2023-02-01 17:29:37 UTC
Created attachment 145971 [details] [review]
Bug 32779: ERM - Fix import from list

There is a typo, '$' is missing, which caused the following error:
Use of inherited AUTOLOAD for non-method Koha::BackgroundJob::CreateEHoldingsFromBiblios::fix_coverage() is no longer allowed at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 126

Test plan:
Create a list, add an item
Turn on ERM
Create a package
Go to /cgi-bin/koha/erm/eholdings/local/titles
Click "Import from list"
Select the package, then your list, and import
It should succeed

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi 2023-02-01 17:34:37 UTC
Fixes the described issue. No QA script complaints.
Thanks Jonathan.
Comment 8 Tomás Cohen Arazi 2023-02-02 15:02:22 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Jacob O'Mara 2023-02-06 15:58:47 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 10 Lucas Gass 2023-02-14 21:44:50 UTC
Not needed in 22.05.x