Summary: | Location on Add Subscription should be pull down | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Serials | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | critical | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, colin.campbell, henridamien, katrin.fischer |
Version: | master | ||
Hardware: | PC | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Incremental fix
Incremental Fix |
Description
Chris Cormack
2010-05-21 01:08:42 UTC
I recommend that this field either be removed to resolved ... Took at look at the field in a user's database. As it has been offered up as a free text field it has in a few cases been used exactly as that. If adding a dropdown we need a consistent usage elsewhere. If not using it as location it needs to be named differently. Will look at it If it's supposed to be used as a free text field, what kind of data are you entering here and where does it appear? It seems that we already have a location - shelving location - and that's what most people think this is for. I'll have to poke at it some more. I didn't say it was supposed to be a free text field (if it was we should probably relabel it). The root problem is that it isn't clearly defined what its purpose is. At the moment it is just entered and saved. :) got it!! I still want to poke and see how it's displaying that data if at all .. if not then if people are entering data in that field we might (like you say) have to rename it and then add in a shelving location field. Okay one more update - the Location appears on the staff client on the summary of the subscription, but no where else - not in the OPAC and not on the bib record in the staff client (that I see). When you specify a Location when saving/editing a subscription it gets saved in the subscriptions table, but then the information is not used anywhere else. My guess is that the intention is for the location value to then be used when adding an item? I would think we could use the information to preselect the location in the serial add item form. Created attachment 2532 [details] [review] Incremental fix - Adds location dropdown to subscription edit form - Pulls authorised value for display on subscription detail page - Adds function for pulling authorised value description based on category and value This patch does NOT implement automatic preselection of the shelving location form field on the serial add item screen. This must be worked out in order for the bug to be closed. Original patch will probably not apply cleanly anymore. A revised version of this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-3285-Locatino-dropdown-serials-2010-08-17 Created attachment 2803 [details]
Incremental Fix
The latest version of the bugfix had a syntax error (missing } ) this tested version corrects that
Partial patch pushed, awaiting follow up patch I confirm that the first patch works A-OK but will not close as we are waiting for more. This bug is mentioned in: Incremental fix for Bug 3285 - Location on Add Subscription should be pull down http://lists.koha-community.org/pipermail/koha-patches/2010-December/013167.html the behaviour to have the location pre-selected when serials add items is in another ticket/patch, so closing this one > the behaviour to have the location pre-selected when serials add items is in
> another ticket/patch
Which one?
|