---- Reported by firstname.lastname@example.org 2009-06-03 10:25:10 ----
[06:21] <hdl_laptop> nengard: location in subscription is added in order to add kind of items.location default for issue received.
[06:21] <nengard> isn't that shelving location? If so it's an authorized value and should be a pull down not a free text field .... right?
[06:21] <gmcharlt> hdl_laptop: hmm - raises a question for me, then, as it doesn't seem to be actually setting it as a default for new received items
[06:21] <gmcharlt> and nengard is right about the drop-down
[06:22] <nengard> that's why i was so confused when I saw it originally
[06:22] <nahuel> yo
[06:22] <hdl_laptop> nengard: gmcharlt yes.
[06:22] <nahuel> arf
[06:22] <hdl_laptop> It is forecast.
[06:23] <gmcharlt> "light periods of snow, followed by raining patches"
[06:23] <hdl_laptop> Not done because done for a migration purpose.
[06:24] <gmcharlt> nengard: please file a bug so we don't lose track
[06:24] <nengard> will do
---- Additional Comments From email@example.com 2009-12-11 13:03:02 ----
I am upping the severity since you can't use this field without the pull down in place.
--- Bug imported by firstname.lastname@example.org 2010-05-21 01:08 UTC ---
This bug was previously known as _bug_ 3285 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3285
Actual time not defined. Setting to 0.0
CC member email@example.com does not have an account here
I recommend that this field either be removed to resolved ...
Took at look at the field in a user's database. As it has been offered up as a free text field it has in a few cases been used exactly as that. If adding a dropdown we need a consistent usage elsewhere. If not using it as location it needs to be named differently. Will look at it
If it's supposed to be used as a free text field, what kind of data are you entering here and where does it appear? It seems that we already have a location - shelving location - and that's what most people think this is for. I'll have to poke at it some more.
I didn't say it was supposed to be a free text field (if it was we should probably relabel it). The root problem is that it isn't clearly defined what its purpose is. At the moment it is just entered and saved.
:) got it!! I still want to poke and see how it's displaying that data if at all .. if not then if people are entering data in that field we might (like you say) have to rename it and then add in a shelving location field.
Okay one more update - the Location appears on the staff client on the summary of the subscription, but no where else - not in the OPAC and not on the bib record in the staff client (that I see).
When you specify a Location when saving/editing a subscription it gets saved in the subscriptions table, but then the information is not used anywhere else. My guess is that the intention is for the location value to then be used when adding an item? I would think we could use the information to preselect the location in the serial add item form.
Created attachment 2532 [details] [review]
- Adds location dropdown to subscription edit form
- Pulls authorised value for display on subscription detail page
- Adds function for pulling authorised value description based
on category and value
This patch does NOT implement automatic preselection of the shelving location form field on the serial add item screen. This must be worked out in order for the bug to be closed.
Original patch will probably not apply cleanly anymore. A revised version of
this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-3285-Locatino-dropdown-serials-2010-08-17
Created attachment 2803 [details]
The latest version of the bugfix had a syntax error (missing } ) this tested version corrects that
Partial patch pushed, awaiting follow up patch
I confirm that the first patch works A-OK but will not close as we are waiting for more.
This bug is mentioned in:
Incremental fix for Bug 3285 - Location on Add Subscription should be pull down http://lists.koha-community.org/pipermail/koha-patches/2010-December/013167.html
the behaviour to have the location pre-selected when serials add items is in another ticket/patch, so closing this one
> the behaviour to have the location pre-selected when serials add items is in
> another ticket/patch