Bug 32899

Summary: Unused ILL configs in koha-conf.xml should be removed
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, magnus, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19822    
Bug Blocks:    

Description Pedro Amorim 2023-02-07 16:38:03 UTC
staff_request_comments and reply_date in koha-conf.xml are only used in _censor method in Koha::Illrequest but this _censor method is not used anywhere else in Koha.
Bug 19822 aims to move ILL config from koha-conf.xml into system preferences, but would it make sense to move configs that are not being used anywhere?

Some ILL backends may use these, but all that I have checked so far do not.
Backends maintained by PTFS-Europe do not use these.
Tomas has confirmed the backends he maintains do not use these.

Asking others in the community for confirmation and opinion on this.
Comment 1 Katrin Fischer 2023-02-07 22:14:14 UTC
I guess Tomas' check included ours, but I can confirm we don't use it.