Bug 32899 - Unused ILL configs in koha-conf.xml should be removed
Summary: Unused ILL configs in koha-conf.xml should be removed
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on: 19822
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-07 16:38 UTC by Pedro Amorim
Modified: 2023-02-07 22:14 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-02-07 16:38:03 UTC 
staff_request_comments and reply_date in koha-conf.xml are only used in _censor method in Koha::Illrequest but this _censor method is not used anywhere else in Koha.
Bug 19822 aims to move ILL config from koha-conf.xml into system preferences, but would it make sense to move configs that are not being used anywhere?

Some ILL backends may use these, but all that I have checked so far do not.
Backends maintained by PTFS-Europe do not use these.
Tomas has confirmed the backends he maintains do not use these.

Asking others in the community for confirmation and opinion on this.
Comment 1 Katrin Fischer 2023-02-07 22:14:14 UTC 
I guess Tomas' check included ours, but I can confirm we don't use it.