Summary: | Filters missing in SQL builder on Orders::filter_by_active | ||
---|---|---|---|
Product: | Koha | Reporter: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
Component: | Acquisitions | Assignee: | Thibaud Guillot (thibaud_g) <thibaud.guillot> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 20212 | ||
Bug Blocks: | |||
Attachments: | Bug 32928: Add filters on Orders::filter_by_active |
Description
Thibaud Guillot (thibaud_g)
2023-02-09 15:21:01 UTC
Created attachment 146437 [details] [review] Bug 32928: Add filters on Orders::filter_by_active To have the same behavior than before 21.xx.xx filters must be added to the filter_by_active function. If not you can have on your list, some orders that can be cancelled, or orders with quantity totally received. Requirements: Have instances with different Koha version (20.11 VS Master for example) Test plan: 1) Apply this patch on Master Just have the same database with pending orders, and see differences between both instances on parcel.pl receptions. You will see that total of orders will be not the same Please provide tests. Oups there is a typo. Backslash there : + 'quantityreceived' => { '<' => \'me.quantity' } (In reply to Fridolin Somers from comment #3) > Oups there is a typo. > Backslash there : > + 'quantityreceived' => { '<' => \'me.quantity' } Forget that, it is a string ref, completely normal :D |