Bug 32941

Summary: Sys prefs side menu styling applying where not intended
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: Staff interfaceAssignee: Pedro Amorim <pedro.amorim>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, jacob.omara, jonathan.druart, katrin.fischer, lucas, martin.renvoize
Version: MainKeywords: rel_22_11_candidate
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32881
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Bug Depends on: 32881    
Bug Blocks:    
Attachments: Bug 32941: Sys prefs side menu styling applying where not intended
Bug 32941: Sys prefs side menu styling applying where not intended
Bug 32941: Sys prefs side menu styling applying where not intended

Description Pedro Amorim 2023-02-10 14:59:04 UTC

    
Comment 1 Pedro Amorim 2023-02-10 15:03:48 UTC
Created attachment 146485 [details] [review]
Bug 32941: Sys prefs side menu styling applying where not intended

In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places.
The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector.
Comment 2 Jonathan Druart 2023-02-14 09:54:48 UTC
I don't see the differences, could you attach before/after screenshots?
Comment 3 Jonathan Druart 2023-02-14 10:08:15 UTC
Created attachment 146611 [details] [review]
Bug 32941: Sys prefs side menu styling applying where not intended

In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places.
The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-02-14 10:12:18 UTC
Before: https://snipboard.io/ZCiV6F.jpg
After : https://snipboard.io/t13nle.jpg

We are looking at the background color of the eHoldings sub menu items.
Comment 5 Katrin Fischer 2023-02-20 22:40:33 UTC
Created attachment 146982 [details] [review]
Bug 32941: Sys prefs side menu styling applying where not intended

In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places.
The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-02-22 12:08:29 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-02-24 11:33:18 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Jacob O'Mara 2023-02-24 11:36:30 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Owen Leonard 2023-09-29 11:48:29 UTC
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.