Bug 32941 - Sys prefs side menu styling applying where not intended
Summary: Sys prefs side menu styling applying where not intended
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Pedro Amorim
QA Contact: Katrin Fischer
URL:
Keywords: rel_22_11_candidate
Depends on: 32881
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-10 14:59 UTC by Pedro Amorim
Modified: 2023-09-29 11:48 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32941: Sys prefs side menu styling applying where not intended (1.45 KB, patch)
2023-02-10 15:03 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32941: Sys prefs side menu styling applying where not intended (1.52 KB, patch)
2023-02-14 10:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32941: Sys prefs side menu styling applying where not intended (1.58 KB, patch)
2023-02-20 22:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-02-10 14:59:04 UTC

    
Comment 1 Pedro Amorim 2023-02-10 15:03:48 UTC
Created attachment 146485 [details] [review]
Bug 32941: Sys prefs side menu styling applying where not intended

In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places.
The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector.
Comment 2 Jonathan Druart 2023-02-14 09:54:48 UTC
I don't see the differences, could you attach before/after screenshots?
Comment 3 Jonathan Druart 2023-02-14 10:08:15 UTC
Created attachment 146611 [details] [review]
Bug 32941: Sys prefs side menu styling applying where not intended

In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places.
The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-02-14 10:12:18 UTC
Before: https://snipboard.io/ZCiV6F.jpg
After : https://snipboard.io/t13nle.jpg

We are looking at the background color of the eHoldings sub menu items.
Comment 5 Katrin Fischer 2023-02-20 22:40:33 UTC
Created attachment 146982 [details] [review]
Bug 32941: Sys prefs side menu styling applying where not intended

In bug 32881 I introduced changes to make system preferences sub menu items easier to read. At the time, I couldn't find other instances of ul ul in the templates code, but turns out the ERM module has a <ul> inside a <ul>, and possibly other places.
The original selector was too loose and was applying where not intended, this patch rolls back 32881 changes and puts the changes in a tighter selector.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-02-22 12:08:29 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-02-24 11:33:18 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Jacob O'Mara 2023-02-24 11:36:30 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Owen Leonard 2023-09-29 11:48:29 UTC
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.