Bug 32945

Summary: Capitalization: id (part 2)
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: jonathan.druart, martin.renvoize, matt.blenkinsop
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32222
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:
Attachments: Bug 32945: Fix capitalization of id in more places
Bug 32945: Fix capitalization of id in more places
Bug 32945: Fix capitalization of id in more places
Bug 32945: (QA follow-up) Fix capitalization of id in even more places
Bug 32945: Fix capitalization of id in more places
Bug 32945: (QA follow-up) Fix capitalization of id in even more places

Description Katrin Fischer 2023-02-10 20:38:52 UTC

    
Comment 1 Katrin Fischer 2023-02-10 20:51:34 UTC
Created attachment 146519 [details] [review]
Bug 32945: Fix capitalization of id in more places

id should be spelled ID, ids should be IDs as it's
an abbreviation according to:

https://www.oxfordlearnersdictionaries.com/definition/english/identification

To test:
* Some of these are hard to make happen or require specific
  data, easiest will be to review the patch itself closely.
Comment 2 Owen Leonard 2023-02-13 13:00:00 UTC
Created attachment 146577 [details] [review]
Bug 32945: Fix capitalization of id in more places

id should be spelled ID, ids should be IDs as it's
an abbreviation according to:

https://www.oxfordlearnersdictionaries.com/definition/english/identification

To test:
* Some of these are hard to make happen or require specific
  data, easiest will be to review the patch itself closely.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2023-02-23 10:27:58 UTC
Found those ones:

koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt:                    <p>The record id <em>[% RECORDID | html %]</em> doesn't match any existing record.</p>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt:                    <p>The import id number <em>[% IMPORTID | html %]</em> doesn't match any existing record.</p>

koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt:      <span>The authority id [% message.authid | html %] does not exist in the database.</span>

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt:                                <p>A payment with the transaction id '[% message_value | html %]' has already been posted to an account.</p>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt:                                <p>The transaction id '[% message_value | html %]' for this payment is invalid.</p>

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt:                                ERROR: No record found for record id [% bad_biblionumber | html %].
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt:                               ERROR: No record id specified.
Comment 4 Katrin Fischer 2023-02-23 22:32:12 UTC
Created attachment 147276 [details] [review]
Bug 32945: Fix capitalization of id in more places

id should be spelled ID, ids should be IDs as it's
an abbreviation according to:

https://www.oxfordlearnersdictionaries.com/definition/english/identification

To test:
* Some of these are hard to make happen or require specific
  data, easiest will be to review the patch itself closely.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Katrin Fischer 2023-02-23 22:32:14 UTC
Created attachment 147277 [details] [review]
Bug 32945: (QA follow-up) Fix capitalization of id in even more places

This fixes additional strings pointed out by QA.
Comment 6 Jonathan Druart 2023-03-23 08:03:50 UTC
Created attachment 148586 [details] [review]
Bug 32945: Fix capitalization of id in more places

id should be spelled ID, ids should be IDs as it's
an abbreviation according to:

https://www.oxfordlearnersdictionaries.com/definition/english/identification

To test:
* Some of these are hard to make happen or require specific
  data, easiest will be to review the patch itself closely.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2023-03-23 08:03:52 UTC
Created attachment 148587 [details] [review]
Bug 32945: (QA follow-up) Fix capitalization of id in even more places

This fixes additional strings pointed out by QA.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Tomás Cohen Arazi (tcohen) 2023-03-27 10:06:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-04-11 09:01:44 UTC
Nice work everyone!

Pushed to stable for 22.11.x