Bug 32222 - Capitalization: id
Summary: Capitalization: id
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-16 00:15 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32222: Fix capitalization in various "id is invalid" (7.35 KB, patch)
2023-02-05 00:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32222: Fix capitalization in various "id is invalid" (7.40 KB, patch)
2023-02-06 13:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32222: Fix capitalization in various "id is invalid" (7.48 KB, patch)
2023-02-07 13:12 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-16 00:15:55 UTC
ID is an abbreviation and should be written with capitals.

See: https://www.oxfordlearnersdictionaries.com/definition/english/identification

Found these instances while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:73
An error occurred trying to open the identity provider domain for editing. The passed id is invalid.

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:69
An error occurred trying to open the identity provider for editing. The passed id is invalid.
Comment 1 Katrin Fischer 2023-02-05 00:53:42 UTC
Created attachment 146181 [details] [review]
Bug 32222: Fix capitalization in various "id is invalid"

ID is an abbreviation and should be written with capitals.

See: https://www.oxfordlearnersdictionaries.com/definition/english/identification

This fixes all occurences of "id is invalid" to read "ID is invalid"

To test:
* As some are hard to trigger warnings, the best way here is to review the patch.
Comment 2 Owen Leonard 2023-02-06 13:46:30 UTC
Created attachment 146271 [details] [review]
Bug 32222: Fix capitalization in various "id is invalid"

ID is an abbreviation and should be written with capitals.

See: https://www.oxfordlearnersdictionaries.com/definition/english/identification

This fixes all occurences of "id is invalid" to read "ID is invalid"

To test:
* As some are hard to trigger warnings, the best way here is to review the patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2023-02-06 17:59:15 UTC
Thanks Owen :)
Comment 4 Martin Renvoize 2023-02-07 13:12:27 UTC
Created attachment 146322 [details] [review]
Bug 32222: Fix capitalization in various "id is invalid"

ID is an abbreviation and should be written with capitals.

See: https://www.oxfordlearnersdictionaries.com/definition/english/identification

This fixes all occurences of "id is invalid" to read "ID is invalid"

To test:
* As some are hard to trigger warnings, the best way here is to review the patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-02-07 13:13:44 UTC
Good catch.. Passing QA on this one..

However, there are more cases of 'id' littered around the templates.. not all that easy to find but there.. a number in syspref descriptions I believe (rg " id " helped me spot a few)... maybe a follow-up bug could be done for the rest?
Comment 6 Tomás Cohen Arazi 2023-02-07 13:51:19 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-02-08 16:37:45 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Lucas Gass 2023-02-15 21:14:03 UTC
Doesn't apply cleanly to 22.05.x, no backport