ID is an abbreviation and should be written with capitals. See: https://www.oxfordlearnersdictionaries.com/definition/english/identification Found these instances while translating: koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:73 An error occurred trying to open the identity provider domain for editing. The passed id is invalid. koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:69 An error occurred trying to open the identity provider for editing. The passed id is invalid.
Created attachment 146181 [details] [review] Bug 32222: Fix capitalization in various "id is invalid" ID is an abbreviation and should be written with capitals. See: https://www.oxfordlearnersdictionaries.com/definition/english/identification This fixes all occurences of "id is invalid" to read "ID is invalid" To test: * As some are hard to trigger warnings, the best way here is to review the patch.
Created attachment 146271 [details] [review] Bug 32222: Fix capitalization in various "id is invalid" ID is an abbreviation and should be written with capitals. See: https://www.oxfordlearnersdictionaries.com/definition/english/identification This fixes all occurences of "id is invalid" to read "ID is invalid" To test: * As some are hard to trigger warnings, the best way here is to review the patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Thanks Owen :)
Created attachment 146322 [details] [review] Bug 32222: Fix capitalization in various "id is invalid" ID is an abbreviation and should be written with capitals. See: https://www.oxfordlearnersdictionaries.com/definition/english/identification This fixes all occurences of "id is invalid" to read "ID is invalid" To test: * As some are hard to trigger warnings, the best way here is to review the patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch.. Passing QA on this one.. However, there are more cases of 'id' littered around the templates.. not all that easy to find but there.. a number in syspref descriptions I believe (rg " id " helped me spot a few)... maybe a follow-up bug could be done for the rest?
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply cleanly to 22.05.x, no backport