Bug 33018

Summary: debian package tidy-up
Product: Koha Reporter: Mason James <mtj>
Component: PackagingAssignee: Mason James <mtj>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: blawlor, dcook, jonathan.druart, m.de.rooy, magnus, martin.renvoize, mtj, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 33018: debian package tidy-up
Bug 33018: debian package tidy-up
Bug 33018: debian package tidy-up (2)

Description Mason James 2023-02-21 02:48:59 UTC
this bug aims to track a tidy-up of debian package files
Comment 1 Mason James 2023-02-21 02:51:51 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2023-03-29 12:21:59 UTC
It looks like these modules are still in use in Koha? 

$ grep -rn "LWP::Protocol" *
cpanfile:62:requires 'LWP::Protocol::https', '5.836';
debian/list-deps:30:    'LWP::Protocol::https' => 'liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl',

$ grep -rn "IO::Socket::IP" *
debian/list-deps:32:    'IO::Socket::IP'       => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl',
misc/bin/connexion_import_daemon.pl:91:# use IO::Socket::IP;

$ grep -rn "CPAN::Meta" *
cpanfile:15:requires 'CPAN::Meta', '2.150006';
debian/list-deps:33:    'CPAN::Meta'           => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)',

So the point is that we had to provide them in the Koha Debian repo, but now we don't have to do that anymore, and we can remove them from "special treatment"?
Comment 3 Magnus Enger 2023-03-29 12:23:31 UTC
Created attachment 148910 [details] [review]
Bug 33018: debian package tidy-up

this patch removes unneeded package dependencies

to test:
 - apply patch
 - build and install koha-common package, note success

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Not tested, I trust Mason to the right thing.
Comment 4 Magnus Enger 2023-03-29 12:24:15 UTC
Please reset to NSO if thorough testing is considered necessary.
Comment 5 David Cook 2023-04-26 03:39:13 UTC
(In reply to Magnus Enger from comment #2)
> So the point is that we had to provide them in the Koha Debian repo, but now
> we don't have to do that anymore, and we can remove them from "special
> treatment"?

I think this question should be answered before this issue is progressed.
Comment 6 Mason James 2023-04-27 09:57:13 UTC
Created attachment 150288 [details] [review]
Bug 33018: debian package tidy-up (2)

remove unrequired module
Comment 7 Mason James 2023-04-27 10:06:30 UTC
(In reply to Magnus Enger from comment #2)
> It looks like these modules are still in use in Koha? 
> 
> $ grep -rn "LWP::Protocol" *
> cpanfile:62:requires 'LWP::Protocol::https', '5.836';
> debian/list-deps:30:    'LWP::Protocol::https' =>
> 'liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl',

this pkg is required, but no longer needs to be explicitly listed in deb/list-deps

> 
> $ grep -rn "IO::Socket::IP" *
> debian/list-deps:32:    'IO::Socket::IP'       => 'perl-modules (>= 5.20.0)
> | libio-socket-ip-perl',
> misc/bin/connexion_import_daemon.pl:91:# use IO::Socket::IP;

this pkg is not required, as its now provided by perl-modules-* pkg

> 
> $ grep -rn "CPAN::Meta" *
> cpanfile:15:requires 'CPAN::Meta', '2.150006';
> debian/list-deps:33:    'CPAN::Meta'           => 'libcpan-meta-perl (>=
> 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>=
> 5.20.2)',

this pkg is not required, as its now provided by perl-modules-* pkg
Comment 8 Magnus Enger 2023-04-27 11:07:46 UTC
Thanks Mason, sounds good!
Comment 9 Jonathan Druart 2023-05-03 09:52:58 UTC
I would not remove CPAN::Meta from the cpanfile: 

  commit a34d086a24b1e4519f8b31331d4c42b87b8e4a83
  Bug 19735: Move Perl deps definitions into a cpanfile

    Added dependencies:
     - Module::CPANfile
     - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent
       version than the one Module::CPANfile requires)
Comment 10 Jonathan Druart 2023-05-16 10:22:03 UTC
Mason, ping?
Comment 11 Mason James 2023-07-16 09:36:49 UTC
(In reply to Jonathan Druart from comment #9)
> I would not remove CPAN::Meta from the cpanfile: 

hi Jonathan, sorry for the late reply

sounds good to me, i'll obsolete the patch
Comment 12 Katrin Fischer 2023-07-29 21:55:34 UTC
I am not sure how to QA this one - can someone else take over please?

I notice there is still this line in the patch:
-    'CPAN::Meta'           => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)',
Comment 13 Marcel de Rooy 2023-08-25 09:03:41 UTC
(In reply to Magnus Enger from comment #3)
> Created attachment 148910 [details] [review] [review]
> Bug 33018: debian package tidy-up
> 
> this patch removes unneeded package dependencies
> 
> to test:
>  - apply patch
>  - build and install koha-common package, note success
> 
> Signed-off-by: Magnus Enger <magnus@libriotech.no>
> Not tested, I trust Mason to the right thing.

Sorry, but I am moving back status. Signoff means test. QA is reading too :)
Comment 14 Pedro Amorim 2023-12-22 10:52:11 UTC
Hi, I'd like to help here but I don't think I'm qualified to.
What is list-deps used for exactly, why did it need the now removed entries, why are they now being removed and how does list-deps relate to cpanfile.
Ignore the questions above if they're irrelevant in moving this bug.
Comment 15 Martin Renvoize 2024-06-04 15:53:31 UTC
Are we still keen to do this Mason?