this bug aims to track a tidy-up of debian package files
Created attachment 146996 [details] [review] Bug 33018: debian package tidy-up this patch removes unneeded package dependencies to test: - apply patch - build and install koha-common package, note success
It looks like these modules are still in use in Koha? $ grep -rn "LWP::Protocol" * cpanfile:62:requires 'LWP::Protocol::https', '5.836'; debian/list-deps:30: 'LWP::Protocol::https' => 'liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl', $ grep -rn "IO::Socket::IP" * debian/list-deps:32: 'IO::Socket::IP' => 'perl-modules (>= 5.20.0) | libio-socket-ip-perl', misc/bin/connexion_import_daemon.pl:91:# use IO::Socket::IP; $ grep -rn "CPAN::Meta" * cpanfile:15:requires 'CPAN::Meta', '2.150006'; debian/list-deps:33: 'CPAN::Meta' => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)', So the point is that we had to provide them in the Koha Debian repo, but now we don't have to do that anymore, and we can remove them from "special treatment"?
Created attachment 148910 [details] [review] Bug 33018: debian package tidy-up this patch removes unneeded package dependencies to test: - apply patch - build and install koha-common package, note success Signed-off-by: Magnus Enger <magnus@libriotech.no> Not tested, I trust Mason to the right thing.
Please reset to NSO if thorough testing is considered necessary.
(In reply to Magnus Enger from comment #2) > So the point is that we had to provide them in the Koha Debian repo, but now > we don't have to do that anymore, and we can remove them from "special > treatment"? I think this question should be answered before this issue is progressed.
Created attachment 150288 [details] [review] Bug 33018: debian package tidy-up (2) remove unrequired module
(In reply to Magnus Enger from comment #2) > It looks like these modules are still in use in Koha? > > $ grep -rn "LWP::Protocol" * > cpanfile:62:requires 'LWP::Protocol::https', '5.836'; > debian/list-deps:30: 'LWP::Protocol::https' => > 'liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl', this pkg is required, but no longer needs to be explicitly listed in deb/list-deps > > $ grep -rn "IO::Socket::IP" * > debian/list-deps:32: 'IO::Socket::IP' => 'perl-modules (>= 5.20.0) > | libio-socket-ip-perl', > misc/bin/connexion_import_daemon.pl:91:# use IO::Socket::IP; this pkg is not required, as its now provided by perl-modules-* pkg > > $ grep -rn "CPAN::Meta" * > cpanfile:15:requires 'CPAN::Meta', '2.150006'; > debian/list-deps:33: 'CPAN::Meta' => 'libcpan-meta-perl (>= > 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= > 5.20.2)', this pkg is not required, as its now provided by perl-modules-* pkg
Thanks Mason, sounds good!
I would not remove CPAN::Meta from the cpanfile: commit a34d086a24b1e4519f8b31331d4c42b87b8e4a83 Bug 19735: Move Perl deps definitions into a cpanfile Added dependencies: - Module::CPANfile - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent version than the one Module::CPANfile requires)
Mason, ping?
(In reply to Jonathan Druart from comment #9) > I would not remove CPAN::Meta from the cpanfile: hi Jonathan, sorry for the late reply sounds good to me, i'll obsolete the patch
I am not sure how to QA this one - can someone else take over please? I notice there is still this line in the patch: - 'CPAN::Meta' => 'libcpan-meta-perl (>= 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= 5.20.2)',
(In reply to Magnus Enger from comment #3) > Created attachment 148910 [details] [review] [review] > Bug 33018: debian package tidy-up > > this patch removes unneeded package dependencies > > to test: > - apply patch > - build and install koha-common package, note success > > Signed-off-by: Magnus Enger <magnus@libriotech.no> > Not tested, I trust Mason to the right thing. Sorry, but I am moving back status. Signoff means test. QA is reading too :)
Hi, I'd like to help here but I don't think I'm qualified to. What is list-deps used for exactly, why did it need the now removed entries, why are they now being removed and how does list-deps relate to cpanfile. Ignore the questions above if they're irrelevant in moving this bug.