Bug 33056

Summary:	Terminology: change 'fine' to 'charge' when making a payment/writeoff
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Templates	Assignee:	Katrin Fischer <katrin.fischer>
Status:	RESOLVED FIXED	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	minor
Priority:	P5 - low	CC:	caroline.cyr-la-rose, martin.renvoize
Version:	unspecified	Keywords:	Academy
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33058
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.04
Circulation function:
Attachments:	Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff

Description Caroline Cyr La Rose 2023-02-23 16:10:02 UTC

In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines).

The term should be changed in paycollect.tt, which is the page when paying or writing off a charge in a patron's account.

To access this page and all strings:
1. Add a manual fee to a patron's account
1.1. Go to a patron's account > Accounting tab
1.2. Click 'Create manual invoice'
1.3. Enter an amount
1.4. Click 'Save'
2. Pay an individual charge
2.1. Click 'Make a payment'
2.2. Click the 'Pay' button next to an individual charge
--> In the browser tab title, it says 'Collect fine payment for ...'
--> In the breadcrumbs, the last section is 'Pay an individual fine'
--> The heading of the page is 'Pay an individual fine'
--> The heading inside the payment tab is 'Pay an individual fine'
2.3. Click 'Cancel' and go back to the 'Make a payment' tab
3. Pay an amount toward all charges
3.1. Click 'Pay amount'
--> In the browser tab title, it says 'Collect fine payment for ...'
--> In the breadcrumbs, the last section is 'Pay an amount toward all fines'
--> The heading of the page is 'Pay an amount toward all fines'
--> The heading inside the payment tab is 'Pay an amount toward all fines'
3.2. Click 'Cancel' and go back to the 'Make a payment' tab
4. Pay an amount toward selected charges
4.1. Click 'Pay selected'
--> In the browser tab title, it says 'Collect fine payment for ...'
--> In the breadcrumbs, the last section is 'Pay an amount toward selected fines'
--> The heading of the page is 'Pay an amount toward selected fines'
--> The heading inside the payment tab is 'Pay an amount toward selected fines'
4.2. Click 'Cancel' and go back to the 'Make a payment' tab
5. Write off an individual charge
5.1. Click the 'Write off' button next to an individual charge
--> In the browser tab title, it says 'Collect fine payment for ...'
--> In the breadcrumbs, the last section is 'Write off an individual fine'
--> The heading of the page is 'Write off an individual fine'
--> The heading inside the payment tab is 'Write off an individual fine'
5.2. Click 'Cancel' and go back to the 'Make a payment' tab
6. Write off selected charges
6.1. Click 'Writeoff selected'
--> In the browser tab title, it says 'Write off an amount for ...'
--> In the breadcrumbs, the last section is 'Write off an amount toward selected fines'
--> The heading of the page is 'Write off an amount toward selected fines'
--> The heading inside the payment tab is 'Write off an amount toward selected fines'
6.2. Click 'Cancel' and go back to the 'Make a payment' tab

Comment 1 Katrin Fischer 2023-03-03 20:44:13 UTC

Created attachment 147740 [details] [review]
Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff

In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines).

To test:
0. Go to patron's account accounting tab, Make a payment section
   --> It will read: X has no outstanding fines.
   0.1 Create a manual invoice
   --> Use "Write off all" button, verify confirmation message says 'fines'
1. Add a manual fee to a patron's account
   1.1. Go to a patron's account > Accounting tab
   1.2. Click 'Create manual invoice'
   1.3. Enter an amount
   1.4. Click 'Save'
2. Pay an individual charge
   2.1. Click 'Make a payment'
   2.2. Click the 'Pay' button next to an individual charge
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an individual fine'
   --> The heading of the page is 'Pay an individual fine'
   --> The heading inside the payment tab is 'Pay an individual fine'
   2.3. Click 'Cancel' and go back to the 'Make a payment' tab
3. Pay an amount toward all charges
   3.1. Click 'Pay amount'
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an amount toward all fines'
   --> The heading of the page is 'Pay an amount toward all fines'
   --> The heading inside the payment tab is 'Pay an amount toward all fines'
   3.2. Click 'Cancel' and go back to the 'Make a payment' tab
4. Pay an amount toward selected charges
   4.1. Click 'Pay selected'
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines'
   --> The heading of the page is 'Pay an amount toward selected fines'
   --> The heading inside the payment tab is 'Pay an amount toward selected fines'
   4.2. Click 'Cancel' and go back to the 'Make a payment' tab
5. Write off an individual charge
   5.1. Click the 'Write off' button next to an individual charge
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Write off an individual fine'
   --> The heading of the page is 'Write off an individual fine'
   --> The heading inside the payment tab is 'Write off an individual fine'
   5.2. Click 'Cancel' and go back to the 'Make a payment' tab
6. Write off selected charges
   6.1. Click 'Writeoff selected'
   --> In the browser tab title, it says 'Write off an amount for ...'
   --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines'
   --> The heading of the page is 'Write off an amount toward selected fines'
   --> The heading inside the payment tab is 'Write off an amount toward selected fines'
   6.2. Click 'Cancel' and go back to the 'Make a payment' tab
7. Apply patch and repeat
   --> All fines should now be charges.

https://bugs.koha-community.org/show_bug.cgi?id=33058

Comment 2 Katrin Fischer 2023-03-03 20:44:43 UTC

Patch on the right bug now :)

Comment 3 Caroline Cyr La Rose 2023-03-03 20:47:41 UTC

Created attachment 147742 [details] [review]
Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff

In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines).

To test:
0. Go to patron's account accounting tab, Make a payment section
   --> It will read: X has no outstanding fines.
   0.1 Create a manual invoice
   --> Use "Write off all" button, verify confirmation message says 'fines'
1. Add a manual fee to a patron's account
   1.1. Go to a patron's account > Accounting tab
   1.2. Click 'Create manual invoice'
   1.3. Enter an amount
   1.4. Click 'Save'
2. Pay an individual charge
   2.1. Click 'Make a payment'
   2.2. Click the 'Pay' button next to an individual charge
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an individual fine'
   --> The heading of the page is 'Pay an individual fine'
   --> The heading inside the payment tab is 'Pay an individual fine'
   2.3. Click 'Cancel' and go back to the 'Make a payment' tab
3. Pay an amount toward all charges
   3.1. Click 'Pay amount'
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an amount toward all fines'
   --> The heading of the page is 'Pay an amount toward all fines'
   --> The heading inside the payment tab is 'Pay an amount toward all fines'
   3.2. Click 'Cancel' and go back to the 'Make a payment' tab
4. Pay an amount toward selected charges
   4.1. Click 'Pay selected'
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines'
   --> The heading of the page is 'Pay an amount toward selected fines'
   --> The heading inside the payment tab is 'Pay an amount toward selected fines'
   4.2. Click 'Cancel' and go back to the 'Make a payment' tab
5. Write off an individual charge
   5.1. Click the 'Write off' button next to an individual charge
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Write off an individual fine'
   --> The heading of the page is 'Write off an individual fine'
   --> The heading inside the payment tab is 'Write off an individual fine'
   5.2. Click 'Cancel' and go back to the 'Make a payment' tab
6. Write off selected charges
   6.1. Click 'Writeoff selected'
   --> In the browser tab title, it says 'Write off an amount for ...'
   --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines'
   --> The heading of the page is 'Write off an amount toward selected fines'
   --> The heading inside the payment tab is 'Write off an amount toward selected fines'
   6.2. Click 'Cancel' and go back to the 'Make a payment' tab
7. Apply patch and repeat
   --> All fines should now be charges.

https://bugs.koha-community.org/show_bug.cgi?id=33058
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Comment 4 Caroline Cyr La Rose 2023-03-03 20:48:31 UTC

I assumed the patch didn't change when it was attached to this bug report from bug 33058. I had already tested and signed it off right away

Comment 5 Martin Renvoize (ashimema) 2023-03-16 09:55:17 UTC

Created attachment 148254 [details] [review]
Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff

In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines).

To test:
0. Go to patron's account accounting tab, Make a payment section
   --> It will read: X has no outstanding fines.
   0.1 Create a manual invoice
   --> Use "Write off all" button, verify confirmation message says 'fines'
1. Add a manual fee to a patron's account
   1.1. Go to a patron's account > Accounting tab
   1.2. Click 'Create manual invoice'
   1.3. Enter an amount
   1.4. Click 'Save'
2. Pay an individual charge
   2.1. Click 'Make a payment'
   2.2. Click the 'Pay' button next to an individual charge
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an individual fine'
   --> The heading of the page is 'Pay an individual fine'
   --> The heading inside the payment tab is 'Pay an individual fine'
   2.3. Click 'Cancel' and go back to the 'Make a payment' tab
3. Pay an amount toward all charges
   3.1. Click 'Pay amount'
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an amount toward all fines'
   --> The heading of the page is 'Pay an amount toward all fines'
   --> The heading inside the payment tab is 'Pay an amount toward all fines'
   3.2. Click 'Cancel' and go back to the 'Make a payment' tab
4. Pay an amount toward selected charges
   4.1. Click 'Pay selected'
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines'
   --> The heading of the page is 'Pay an amount toward selected fines'
   --> The heading inside the payment tab is 'Pay an amount toward selected fines'
   4.2. Click 'Cancel' and go back to the 'Make a payment' tab
5. Write off an individual charge
   5.1. Click the 'Write off' button next to an individual charge
   --> In the browser tab title, it says 'Collect fine payment for ...'
   --> In the breadcrumbs, the last section is 'Write off an individual fine'
   --> The heading of the page is 'Write off an individual fine'
   --> The heading inside the payment tab is 'Write off an individual fine'
   5.2. Click 'Cancel' and go back to the 'Make a payment' tab
6. Write off selected charges
   6.1. Click 'Writeoff selected'
   --> In the browser tab title, it says 'Write off an amount for ...'
   --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines'
   --> The heading of the page is 'Write off an amount toward selected fines'
   --> The heading inside the payment tab is 'Write off an amount toward selected fines'
   6.2. Click 'Cancel' and go back to the 'Make a payment' tab
7. Apply patch and repeat
   --> All fines should now be charges.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 6 Martin Renvoize (ashimema) 2023-03-16 09:55:49 UTC

Woop, Woop.. we're getting there with these now.

Great work

PQA

Comment 7 Tomás Cohen Arazi (tcohen) 2023-03-16 19:31:32 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 8 Matt Blenkinsop 2023-03-17 17:02:50 UTC

Nice work everyone!

Pushed to stable for 22.11.x