Created attachment 147262 [details] [review] Bug 33058: Update "fines" to "charges" for viewing a guarantees charges Charges includes fines and fees, while fines are mostly negative. Changing this according to our terminology guidelines. To test: * Make sure the patron category of your patron is set to be 'can be guarantee' in administration * Set AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor to allow * Set OpacPrivacy to allow * Edit your patron, give it a guarantor and look at the "Show fines to guarantors setting" and hint * Save and look at the label of the field on the details tab * Go to the OPAC and log in * Check the Privavy tab for the option to allow the guarantee to see your charges * Apply patch. Verify: * System preference descriptions changes * Option and label names have changed in all steps above
Created attachment 147264 [details] [review] Bug 33056: Terminology: change 'fine' to 'charge'when making a payment or writeoff In the development meeting of Feb 22, 2023, we decided to change 'fine' to 'charge' when referring to various types of fees ('fine' should be limited to overdue fines). To test: 0. Go to patron's account accounting tab, Make a payment section --> It will read: X has no outstanding fines. 0.1 Create a manual invoice --> Use "Write off all" button, verify confirmation message says 'fines' 1. Add a manual fee to a patron's account 1.1. Go to a patron's account > Accounting tab 1.2. Click 'Create manual invoice' 1.3. Enter an amount 1.4. Click 'Save' 2. Pay an individual charge 2.1. Click 'Make a payment' 2.2. Click the 'Pay' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an individual fine' --> The heading of the page is 'Pay an individual fine' --> The heading inside the payment tab is 'Pay an individual fine' 2.3. Click 'Cancel' and go back to the 'Make a payment' tab 3. Pay an amount toward all charges 3.1. Click 'Pay amount' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward all fines' --> The heading of the page is 'Pay an amount toward all fines' --> The heading inside the payment tab is 'Pay an amount toward all fines' 3.2. Click 'Cancel' and go back to the 'Make a payment' tab 4. Pay an amount toward selected charges 4.1. Click 'Pay selected' --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Pay an amount toward selected fines' --> The heading of the page is 'Pay an amount toward selected fines' --> The heading inside the payment tab is 'Pay an amount toward selected fines' 4.2. Click 'Cancel' and go back to the 'Make a payment' tab 5. Write off an individual charge 5.1. Click the 'Write off' button next to an individual charge --> In the browser tab title, it says 'Collect fine payment for ...' --> In the breadcrumbs, the last section is 'Write off an individual fine' --> The heading of the page is 'Write off an individual fine' --> The heading inside the payment tab is 'Write off an individual fine' 5.2. Click 'Cancel' and go back to the 'Make a payment' tab 6. Write off selected charges 6.1. Click 'Writeoff selected' --> In the browser tab title, it says 'Write off an amount for ...' --> In the breadcrumbs, the last section is 'Write off an amount toward selected fines' --> The heading of the page is 'Write off an amount toward selected fines' --> The heading inside the payment tab is 'Write off an amount toward selected fines' 6.2. Click 'Cancel' and go back to the 'Make a payment' tab 7. Apply patch and repeat --> All fines should now be charges.
Are both patches supposed to be on this bug report?
Created attachment 147737 [details] [review] Bug 33058: Update "fines" to "charges" for viewing a guarantees charges Charges includes fines and fees, while fines are mostly negative. Changing this according to our terminology guidelines. To test: * Make sure the patron category of your patron is set to be 'can be guarantee' in administration * Set AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor to allow * Set OpacPrivacy to allow * Edit your patron, give it a guarantor and look at the "Show fines to guarantors setting" and hint * Save and look at the label of the field on the details tab * Go to the OPAC and log in * Check the Privavy tab for the option to allow the guarantee to see your charges * Apply patch. Verify: * System preference descriptions changes * Option and label names have changed in all steps above Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
I only signed off the patch for this bug
I tried to sign off the second patch and attach it to the other bug report, but it told me that was illegal :) But I looked at all the strings and it was ok
Nope :)
Created attachment 148232 [details] [review] Bug 33058: Update "fines" to "charges" for viewing a guarantees charges Charges includes fines and fees, while fines are mostly negative. Changing this according to our terminology guidelines. To test: * Make sure the patron category of your patron is set to be 'can be guarantee' in administration * Set AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor to allow * Set OpacPrivacy to allow * Edit your patron, give it a guarantor and look at the "Show fines to guarantors setting" and hint * Save and look at the label of the field on the details tab * Go to the OPAC and log in * Check the Privavy tab for the option to allow the guarantee to see your charges * Apply patch. Verify: * System preference descriptions changes * Option and label names have changed in all steps above Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Correction works as expected.. Passing QA This lead me to do a search in the templates.. there are loads of 'fines' instead of 'charges' still unfortunately :(
(In reply to Martin Renvoize from comment #9) > Correction works as expected.. Passing QA > > This lead me to do a search in the templates.. there are loads of 'fines' > instead of 'charges' still unfortunately :( Bug 33056 fixes some more!
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x