Bug 33059

Summary: Capitalization: Fix sample authorised value descriptions
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Installation and upgrade (web-based installer)Assignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: caroline.cyr-la-rose, david, gmcharlt, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33269
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:
Attachments: Bug 33059: Fix capitalizatoin of AV sample category descriptions
Bug 33059: Fix capitalizatoin of AV sample category descriptions
Bug 33059: Fix capitalizatoin of AV sample category descriptions
Bug 33059: Fix capitalizatoin of AV sample category descriptions

Description Katrin Fischer 2023-02-23 21:07:06 UTC
We still have "Staff Collection" and "Restricted Access" in the sample values for authorised values that don't follow capitalization rules.
Comment 1 Katrin Fischer 2023-02-23 21:24:27 UTC
Created attachment 147271 [details] [review]
Bug 33059: Fix capitalizatoin of AV sample category descriptions

* Fixes capitalization
* Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book)
* Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook)

To test:
* This is a little difficult to test. What you'd need to do:
* Apply the patch
* Drop your database, recreate it, run the web installer
* Make sure to select the optional AV along with the mandatory to install
* Log into Koha after finishing the installer and go to administration >
  authorised values
* Review the existing sample values for incorrect capitalization in
  the different categories
Comment 2 David Nind 2023-03-12 17:31:29 UTC
Created attachment 148110 [details] [review]
Bug 33059: Fix capitalizatoin of AV sample category descriptions

* Fixes capitalization
* Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book)
* Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook)

To test:
* This is a little difficult to test. What you'd need to do:
* Apply the patch
* Drop your database, recreate it, run the web installer
* Make sure to select the optional AV along with the mandatory to install
* Log into Koha after finishing the installer and go to administration >
  authorised values
* Review the existing sample values for incorrect capitalization in
  the different categories

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-03-12 17:33:26 UTC
Testing notes:

1. A reset_all updated all the updated values after applying the patch.

2. I also tested by using the web installer (see https://gitlab.com/-/snippets/1893788#user-content-start-the-web-installer)
Comment 4 Martin Renvoize (ashimema) 2023-03-15 18:01:00 UTC
Created attachment 148239 [details] [review]
Bug 33059: Fix capitalizatoin of AV sample category descriptions

* Fixes capitalization
* Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book)
* Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook)

To test:
* This is a little difficult to test. What you'd need to do:
* Apply the patch
* Drop your database, recreate it, run the web installer
* Make sure to select the optional AV along with the mandatory to install
* Log into Koha after finishing the installer and go to administration >
  authorised values
* Review the existing sample values for incorrect capitalization in
  the different categories

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2023-03-15 18:02:21 UTC
Comment on attachment 148239 [details] [review]
Bug 33059: Fix capitalizatoin of AV sample category descriptions

Review of attachment 148239 [details] [review]:
-----------------------------------------------------------------

::: installer/data/mysql/en/mandatory/auth_values.yml
@@ +4045,5 @@
>  
>          - category: "qualif"
>            authorised_value: "110"
> +          lib: "Binder an agent who binds an item."
> +          lib_opac: "Binder an agent who binds an item."

I'm not 100% sure about this one.. it doesn't read right to me.

"Binder, the agent who binds an item." perhaps?
Comment 6 Caroline Cyr La Rose 2023-03-15 18:21:15 UTC
I find it interesting that Binder is the only relator term with an explanation of what it is... Are we afraid we're going to think that it is like a 3-ring binder type thing? The context of the authorised value list should make it obvious.

I found the list in English here:
https://cdn.ifla.org/wp-content/uploads/U_B_AppB_update2021_ONLINE_FINAL-1.pdf
The explanation is really "An agent who binds an item."

Personally, I would either remove it to match all the other relator terms, or put the explanation in parentheses, but keep the "An agent".
Comment 7 Caroline Cyr La Rose 2023-03-15 18:26:42 UTC
Of course, I'm speaking without *any* UNIMARC experience... I can try to contact the French list and have one of them comment on this.
Comment 8 Katrin Fischer 2023-03-15 21:44:21 UTC
I also stumbled on that one, but maybe we could solve separately? This one was only about cosmetics. :)
Comment 9 Caroline Cyr La Rose 2023-03-16 12:58:35 UTC
(In reply to Katrin Fischer from comment #8)
> I also stumbled on that one, but maybe we could solve separately? This one
> was only about cosmetics. :)

Good idea
Comment 10 Nick Clemens (kidclamp) 2023-03-17 12:22:10 UTC
Created attachment 148333 [details] [review]
Bug 33059: Fix capitalizatoin of AV sample category descriptions

* Fixes capitalization
* Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book)
* Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook)

To test:
* This is a little difficult to test. What you'd need to do:
* Apply the patch
* Drop your database, recreate it, run the web installer
* Make sure to select the optional AV along with the mandatory to install
* Log into Koha after finishing the installer and go to administration >
  authorised values
* Review the existing sample values for incorrect capitalization in
  the different categories

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 11 Tomás Cohen Arazi (tcohen) 2023-03-17 12:59:55 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 12 Matt Blenkinsop 2023-03-17 17:20:58 UTC
Nice work everyone!

Pushed to stable for 22.11.x