Description
Phil Ringnalda
2023-03-01 05:10:28 UTC
*** Bug 36553 has been marked as a duplicate of this bug. *** Created attachment 164656 [details] [review] Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works The main entry form of corporate names (110), uniform titles (130), topical terms (150), geographical names (151), and genre/form (155) are not indexed with 'Match' search field in Elasticsearch standard mapping. As a result, the respective records are not present on the result list when performing an 'All headings' search for the authority records with the main heading form (MARC 21). Test plan ========= 0. Have a test installation with Elasticsearch. 1. In Authorities, make an 'All headings' search for a main entry form from the corporate names, uniform titles, topical terms, geographical names, or genre/form --> e.g., in ktd: UK Archiving. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -a kohadev 3. Repeat the test. You should see 'UK Archiving' on the result list. Created attachment 164659 [details] [review] Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works The main entry form of corporate names (110), uniform titles (130), topical terms (150), geographical names (151), and genre/form (155) are not indexed with 'Match' search field in Elasticsearch standard mapping. As a result, the respective records are not present on the result list when performing an 'All headings' search for the authority records with the main heading form (MARC 21). Test plan ========= 0. Have a test installation with Elasticsearch. 1. In Authorities, make an 'All headings' search for a main entry form from the corporate names, uniform titles, topical terms, geographical names, or genre/form --> e.g., in ktd: UK Archiving. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -a kohadev 3. Repeat the test. You should see 'UK Archiving' on the result list. Created attachment 164868 [details] [review] Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works The main entry form of corporate names (110), uniform titles (130), topical terms (150), geographical names (151), and genre/form (155) are not indexed with 'Match' search field in Elasticsearch standard mapping. As a result, the respective records are not present on the result list when performing an 'All headings' search for the authority records with the main heading form (MARC 21). Test plan ========= 0. Have a test installation with Elasticsearch. 1. In Authorities, make an 'All headings' search for a main entry form from the corporate names, uniform titles, topical terms, geographical names, or genre/form --> e.g., in ktd: UK Archiving. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -a kohadev 3. Repeat the test. You should see 'UK Archiving' on the result list. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> At a glance, this looks very useful. Created attachment 166630 [details] [review] Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works The main entry form of corporate names (110), uniform titles (130), topical terms (150), geographical names (151), and genre/form (155) are not indexed with 'Match' search field in Elasticsearch standard mapping. As a result, the respective records are not present on the result list when performing an 'All headings' search for the authority records with the main heading form (MARC 21). Test plan ========= 0. Have a test installation with Elasticsearch. 1. In Authorities, make an 'All headings' search for a main entry form from the corporate names, uniform titles, topical terms, geographical names, or genre/form --> e.g., in ktd: UK Archiving. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -a kohadev 3. Repeat the test. You should see 'UK Archiving' on the result list. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Obvious improvement, thanks. No QA issues, working as expected. Passing QA I think adding a release note would be helpful here as we fix default mappings, but not the existing installations. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |