Bug 33099 - Add missing MARC21 match authority mappings so "Search all headings" search works
Summary: Add missing MARC21 match authority mappings so "Search all headings" search w...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Janusz Kaczmarek
QA Contact: Martin Renvoize
URL:
Keywords: release-notes-needed
: 36553 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-01 05:10 UTC by Phil Ringnalda
Modified: 2024-05-14 13:35 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works (2.32 KB, patch)
2024-04-11 08:16 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works (2.32 KB, patch)
2024-04-11 08:28 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works (2.37 KB, patch)
2024-04-13 16:32 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works (2.44 KB, patch)
2024-05-13 10:39 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Ringnalda 2023-03-01 05:10:28 UTC
The authorities search option to "Search all headings" is actually the most useful choice, but with ElasticSearch it only really works for personal names and meeting names, because while https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=admin/searchengine/elasticsearch/mappings.yaml;h=e892f9126c2b080fb00a931207f907917128c003;hb=HEAD#l264 maps 4xx and 5xx see and see-also headings for all types of authorities for the Match index, it only maps 100 and 111, missing 110, 130, 148, 150, 151 and 155 for main headings.
Comment 1 Phil Ringnalda 2024-04-10 00:50:36 UTC
*** Bug 36553 has been marked as a duplicate of this bug. ***
Comment 2 Janusz Kaczmarek 2024-04-11 08:16:39 UTC
Created attachment 164656 [details] [review]
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works

The main entry form of corporate names (110), uniform titles (130), topical
terms (150), geographical names (151), and genre/form (155) are not indexed
with 'Match' search field in Elasticsearch standard mapping.  As a result,
the respective records are not present on the result list when performing
an 'All headings' search for the authority records with the main heading form
(MARC 21).

Test plan
=========
0. Have a test installation with Elasticsearch.
1. In Authorities, make an 'All headings' search for a main entry
   form from the corporate names, uniform titles, topical terms,
   geographical names, or genre/form
   --> e.g., in ktd: UK Archiving.  You will get no results.
2. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -a kohadev
3. Repeat the test. You should see 'UK Archiving' on the result list.
Comment 3 Janusz Kaczmarek 2024-04-11 08:28:41 UTC
Created attachment 164659 [details] [review]
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works

The main entry form of corporate names (110), uniform titles (130), topical
terms (150), geographical names (151), and genre/form (155) are not indexed
with 'Match' search field in Elasticsearch standard mapping.  As a result,
the respective records are not present on the result list when performing
an 'All headings' search for the authority records with the main heading form
(MARC 21).

Test plan
=========
0. Have a test installation with Elasticsearch.
1. In Authorities, make an 'All headings' search for a main entry
   form from the corporate names, uniform titles, topical terms,
   geographical names, or genre/form
   --> e.g., in ktd: UK Archiving.  You will get no results.
2. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -a kohadev
3. Repeat the test. You should see 'UK Archiving' on the result list.
Comment 4 Roman Dolny 2024-04-13 16:32:40 UTC
Created attachment 164868 [details] [review]
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works

The main entry form of corporate names (110), uniform titles (130), topical
terms (150), geographical names (151), and genre/form (155) are not indexed
with 'Match' search field in Elasticsearch standard mapping.  As a result,
the respective records are not present on the result list when performing
an 'All headings' search for the authority records with the main heading form
(MARC 21).

Test plan
=========
0. Have a test installation with Elasticsearch.
1. In Authorities, make an 'All headings' search for a main entry
   form from the corporate names, uniform titles, topical terms,
   geographical names, or genre/form
   --> e.g., in ktd: UK Archiving.  You will get no results.
2. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -a kohadev
3. Repeat the test. You should see 'UK Archiving' on the result list.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 5 David Cook 2024-04-15 02:17:38 UTC
At a glance, this looks very useful.
Comment 6 Martin Renvoize 2024-05-13 10:39:01 UTC
Created attachment 166630 [details] [review]
Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works

The main entry form of corporate names (110), uniform titles (130), topical
terms (150), geographical names (151), and genre/form (155) are not indexed
with 'Match' search field in Elasticsearch standard mapping.  As a result,
the respective records are not present on the result list when performing
an 'All headings' search for the authority records with the main heading form
(MARC 21).

Test plan
=========
0. Have a test installation with Elasticsearch.
1. In Authorities, make an 'All headings' search for a main entry
   form from the corporate names, uniform titles, topical terms,
   geographical names, or genre/form
   --> e.g., in ktd: UK Archiving.  You will get no results.
2. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -a kohadev
3. Repeat the test. You should see 'UK Archiving' on the result list.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2024-05-13 10:39:26 UTC
Obvious improvement, thanks.

No QA issues, working as expected.

Passing QA
Comment 8 Katrin Fischer 2024-05-14 13:18:18 UTC
I think adding a release note would be helpful here as we fix default mappings, but not the existing installations.
Comment 9 Katrin Fischer 2024-05-14 13:35:13 UTC
Pushed for 24.05!

Well done everyone, thank you!