| Summary: | Markup error in staff interface tab wrapper | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | martin.renvoize, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
| Circulation function: | |||
| Bug Depends on: | 32571 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33126: Markup error in staff interface tab wrapper
Bug 33126: Markup error in staff interface tab wrapper Bug 33126: Markup error in staff interface tab wrapper |
||
|
Description
Owen Leonard
2023-03-03 13:32:40 UTC
Created attachment 147697 [details] [review] Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a <li> which should be </li>. The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this: <li role="presentation" class="active"> <a href="about_panel" aria-controls="about_panel" role="tab" data-toggle="tab"> Server information </a> <li> After the patch the closing </li> will be correct. Created attachment 147826 [details] [review] Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a <li> which should be </li>. The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this: <li role="presentation" class="active"> <a href="about_panel" aria-controls="about_panel" role="tab" data-toggle="tab"> Server information </a> <li> After the patch the closing </li> will be correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Works as described, thanks for the patch. Created attachment 148231 [details] [review] Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a <li> which should be </li>. The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this: <li role="presentation" class="active"> <a href="about_panel" aria-controls="about_panel" role="tab" data-toggle="tab"> Server information </a> <li> After the patch the closing </li> will be correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Clear correction, passing QA Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |