| Summary: | Tab WRAPPER follow-up: label text must be translatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
| Circulation function: | |||
| Bug Depends on: | 32571 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33154: Tab WRAPPER follow-up: label text must be translatable
Bug 33154: Tab WRAPPER follow-up: label text must be translatable Bug 33154: Tab WRAPPER follow-up: label text must be translatable Bug 33154: Tab WRAPPER follow-up: label text must be translatable |
||
Created attachment 147835 [details] [review] Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Created attachment 148695 [details] [review] Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 149326 [details] [review] Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> QA tools show this warning, but I think it's irrelevant here: * Commit title does not contain 'follow-up' correctly spelt - b9bdec4b71 This might conflict with bug 33332. Created attachment 149592 [details] [review] Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Missing 22.05.x dependencies, no backport. |
The new WRAPPER system for building tabs has the unwanted side-effect of creating a situation where text is not translatable. Because the translation process looks for text inside HTML tags, the string "Server information" will not be picked up for translation: [% WRAPPER tab_item tabname= "about" bt_active= 1 %] Server information [% END %] Strings must be wrapped in <span> (or some variation of "[% t('A translatable string') %]."