Summary: | Category and library filters from header patron search not taken into account | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, koha, kyle.m.hall, lucas, nick, wainuiwitikapark |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.11
|
|
Circulation function: | |||
Bug Depends on: | 7380 | ||
Bug Blocks: | |||
Attachments: |
Bug 33155: Fix category and library filters in patron search header
Bug 33155: Fix category and library filters in patron search header |
Description
Jonathan Druart
2023-03-07 12:55:14 UTC
Created attachment 147834 [details] [review] Bug 33155: Fix category and library filters in patron search header Caused by commit f1925cf89dbc1039fc48abfabad1472289387148 Bug 7380: Rename filter to avoid confusion [% IF categorycode %] - $("#categorycode_filter").val("[% categorycode %]"); + $("#categorycode_filter").val("[% categorycode_filter %]"); [% END %] [% IF branchcode %] - $("#branchcode_filter").val("[% branchcode %]"); + $("#branchcode_filter").val("[% branchcode_filter %]"); [% END %] Forgot to rename the vars in the IF statements Test plan: Go to the Koha mainpage Click "Search patrons" in the headers Open the filters Select something for library and category, search => The values must be picked for the patron search Created attachment 147836 [details] [review] Bug 33155: Fix category and library filters in patron search header Caused by commit f1925cf89dbc1039fc48abfabad1472289387148 Bug 7380: Rename filter to avoid confusion [% IF categorycode %] - $("#categorycode_filter").val("[% categorycode %]"); + $("#categorycode_filter").val("[% categorycode_filter %]"); [% END %] [% IF branchcode %] - $("#branchcode_filter").val("[% branchcode %]"); + $("#branchcode_filter").val("[% branchcode_filter %]"); [% END %] Forgot to rename the vars in the IF statements Test plan: Go to the Koha mainpage Click "Search patrons" in the headers Open the filters Select something for library and category, search => The values must be picked for the patron search Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial fix, PQA Pushed to master for 22.11. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.11 *** Bug 32651 has been marked as a duplicate of this bug. *** This is on 21.11 Not backported to 21.05.x |