Summary: | Reindent the bibliographic details page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This updates the template file used to display the bibliographic detail page in the staff interface. It re-indents the file so that it has consistent indentation, and adds comments to highlight the markup structure. This is a developer-oriented change with no visible effect to the user.
|
|
Version(s) released in: |
24.11.00
|
Circulation function: | |
Bug Depends on: | 33568, 37002 | ||
Bug Blocks: | 33526 | ||
Attachments: |
Bug 33195: Reindent the bibliographic details page
Bug 33195: (follow-up) Add markup comments Three related bibliographic records Bug 33195: Reindent the bibliographic details page Bug 33195: (follow-up) Add markup comments Bug 33195: Reindent the bibliographic details page Bug 33195: (follow-up) Add markup comments Bug 33195: Reindent the bibliographic details page Bug 33195: (follow-up) Add markup comments |
Description
Owen Leonard
2023-03-10 12:49:59 UTC
Created attachment 151432 [details] [review] Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Created attachment 151433 [details] [review] Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 151486 [details]
Three related bibliographic records
This MARC file can be imported and used for testing FRBRizeEditions with ThingISBN
Bug 8377 has a sample MARC file for testing HTML5MediaEnabled: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685 Please don't do this, I am currently working heavily on this template, see bug 33568. (In reply to Jonathan Druart from comment #5) > Please don't do this Okay cool Created attachment 167346 [details] [review] Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Created attachment 167347 [details] [review] Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 167358 [details] [review] Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 167359 [details] [review] Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 168724 [details] [review] Bug 33195: Reindent the bibliographic details page This patch reindents the bibliographic details template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and view the detail page for a bibliographic record. Test as many variations as you can: - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record with component parts - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 168725 [details] [review] Bug 33195: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice cleanup.. PQA Is there a reason this was marked as bug? :) (In reply to Katrin Fischer from comment #14) > Is there a reason this was marked as bug? :) Nope! Pushed for 24.11! Well done everyone, thank you! |