Continuing the work of Bug 32571, I would like to update the bibliographic detail page in the staff client to use the new WRAPPER for tabs
Created attachment 151489 [details] [review] Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs
Created attachment 167352 [details] [review] Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - The components tab should be automatically selected - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - The media tab should be selected by default - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs Sponsored-By: Athens County Public Libraries
Created attachment 167360 [details] [review] Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - The components tab should be automatically selected - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - The media tab should be selected by default - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 168726 [details] [review] Bug 33526: Use template wrapper for tabs: Bibliographic detail page This patch updates the bibliographic detail page so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and view the detail page for a bibliographic record. Test the tabs in as many variations as you can: - With and without SeparateHoldings enabled - With and without cover images enabled - With FRBRizeEditions enabled (and multiple editions in your catalog) - See Bug 33195 for a MARC file to use when testing FRBRizeEditions with ThingISBN - With LocalCoverImages enabled - With AcquisitionDetails enabled - With a serial record - With a record added from a suggestion - With a record with component parts - See Bug 11175 for a MARCXML file to use to test this feature - The components tab should be automatically selected - With EnableItemGroups enabled - Wtih CatalogConcerns enabled - With HTML5MediaEnabled and a record with media links - See Bug 8377 for a MARC file to use to test this feature - The media tab should be selected by default - With and without NovelistSelect enabled (requires Novelist credentials) - With NovelistSelectStaffView set to "above the holdings table," "below the holdings table," and "in a tab" - With a plugin enabled which adds a tab to this view - See Bug 27120 for a sample plugin for testing plugin-generated tabs Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another nice improvement, thanks Owen. PQA
Pushed for 24.11! Well done everyone, thank you!