Bug 33204

Summary: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Command-line UtilitiesAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Kyle M Hall (khall) <kyle>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, kyle, robin
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33239
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34700
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/797 Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on: 19454    
Bug Blocks: 33239    
Attachments: Bug 33204: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl
Bug 33204: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl
Bug 33204: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl
Bug 33204: (QA follow-up) Improve option description

Description Fridolin Somers 2023-03-11 06:31:35 UTC
Like filter on category Bug 19454, it would be helpful to filter on a specified library for misc/maintenance/borrowers-force-messaging-defaults.pl
Comment 1 Fridolin Somers 2023-03-11 06:35:51 UTC
Created attachment 148102 [details] [review]
Bug 33204: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl

Like filter on category Bug 19454, it would be helpful to filter on a specified library for misc/maintenance/borrowers-force-messaging-defaults.pl

Test plan:
1) Select two patrons A and B in say libraries L1 and L2.
2) Change the msg prefs for A and B away from defaults.
3) Run misc/maintenance/borrowers-force-messaging-defaults.pl -doit -library L1
    Verify that patron A changed and patron B did not.
4) Run with both category and library filters
Comment 2 Sam Lau 2023-05-24 21:00:47 UTC
Created attachment 151655 [details] [review]
Bug 33204: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl

Like filter on category Bug 19454, it would be helpful to filter on a specified library for misc/maintenance/borrowers-force-messaging-defaults.pl

Test plan:
1) Select two patrons A and B in say libraries L1 and L2.
2) Change the msg prefs for A and B away from defaults.
3) Run misc/maintenance/borrowers-force-messaging-defaults.pl -doit -library L1
    Verify that patron A changed and patron B did not.
4) Run with both category and library filters

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Kyle M Hall (khall) 2023-09-01 16:52:13 UTC
Created attachment 155135 [details] [review]
Bug 33204: Add the ability to filter on patron library for borrowers-force-messaging-defaults.pl

Like filter on category Bug 19454, it would be helpful to filter on a specified library for misc/maintenance/borrowers-force-messaging-defaults.pl

Test plan:
1) Select two patrons A and B in say libraries L1 and L2.
2) Change the msg prefs for A and B away from defaults.
3) Run misc/maintenance/borrowers-force-messaging-defaults.pl -doit -library L1
    Verify that patron A changed and patron B did not.
4) Run with both category and library filters

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall (khall) 2023-09-01 16:52:19 UTC
Created attachment 155136 [details] [review]
Bug 33204: (QA follow-up) Improve option description

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-10-10 13:56:09 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-12 21:03:01 UTC
Enhancement not pushed to 23.05.x