Bug 33239 - Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name
Summary: Add the ability to run borrowers-force-messaging-defaults.pl only on a specif...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Fridolin Somers
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on: 33204
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-16 02:46 UTC by Fridolin Somers
Modified: 2024-12-23 08:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/797
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name (3.94 KB, patch)
2023-03-16 07:44 UTC, Fridolin Somers 		Details | Diff | Splinter Review
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name (3.94 KB, patch)
2023-03-16 07:55 UTC, Fridolin Somers 		Details | Diff | Splinter Review
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name (3.98 KB, patch)
2023-05-25 15:16 UTC, Sam Lau 		Details | Diff | Splinter Review
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name (4.22 KB, patch)
2023-09-01 17:03 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 33239: (QA follow-up) Tidy and improve description (1.88 KB, patch)
2023-09-01 17:03 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-03-16 02:46:35 UTC 
It would be helpful to run misc/maintenance/borrowers-force-messaging-defaults.pl with a speficied message name.
So apply default category value only on some message (like Item_due) and keep patron choice for the others.
Values of message name can be found in :
https://git.koha-community.org/Koha-community/Koha/src/branch/master/installer/data/mysql/mandatory/sample_notices_message_attributes.sql
Comment 1 Fridolin Somers 2023-03-16 07:44:33 UTC 
Created attachment 148249 [details] [review]
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name

Test plan:
1) Select a patron A
2) Change all the message prefs away from defaults.
3) Run misc/maintenance/borrowers-force-messaging-defaults.pl --doit --message-name Item_due
    Verify that patron A prefs changed only for 'Item due'
Comment 2 Fridolin Somers 2023-03-16 07:55:17 UTC 
Created attachment 148250 [details] [review]
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name

Test plan:
1) Select a patron A
2) Change all the message prefs away from defaults.
3) Run misc/maintenance/borrowers-force-messaging-defaults.pl --doit --message-name Item_due
    Verify that patron A prefs changed only for 'Item due'
Comment 3 Sam Lau 2023-05-25 15:16:58 UTC 
Created attachment 151696 [details] [review]
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name

Test plan:
1) Select a patron A
2) Change all the message prefs away from defaults.
3) Run misc/maintenance/borrowers-force-messaging-defaults.pl --doit --message-name Item_due
    Verify that patron A prefs changed only for 'Item due'

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 Kyle M Hall (khall) 2023-09-01 17:03:09 UTC 
Created attachment 155137 [details] [review]
Bug 33239: Add the ability to run borrowers-force-messaging-defaults.pl only on a specified message name

Test plan:
1) Select a patron A
2) Change all the message prefs away from defaults.
3) Run misc/maintenance/borrowers-force-messaging-defaults.pl --doit --message-name Item_due
    Verify that patron A prefs changed only for 'Item due'

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Kyle M Hall (khall) 2023-09-01 17:03:29 UTC 
Created attachment 155138 [details] [review]
Bug 33239: (QA follow-up) Tidy and improve description

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-10-11 13:34:13 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-12 21:06:17 UTC 
Enhancement not pushed to 23.05.x