Bug 33228

Summary: All charges should be displayed on the patron checkout page
Product: Koha Reporter: Laura Escamilla <Laura.escamilla>
Component: Fines and feesAssignee: Nick Clemens (kidclamp) <nick>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: david, kebliss, lmstrand, nick, smhodson123extra
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38532
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 33228 - Show all charges on the patron details and checkout page
Bug 33228 - Show all charges on the patron details and checkout page
Bug 33228 - Show all charges on the patron details and checkout page in intranet
Bug 33228 - Show all charges on the patron details and checkout page in intranet
Bug 33228: Display all fines on patron details and circulation
Bug 33228: Display all fines on patron details and circulation

Description Laura Escamilla 2023-03-14 15:51:45 UTC
Currently charges are only being displayed on the patron checkout page if they are being used as a restriction. If libraries choose to not restrict patrons because of unpaid fines then the only way they can see the fines is by checking the accounting page. It would be ideal if all unpaid fees could be displayed on the checkout page.
Comment 1 Katrin Fischer 2023-03-14 16:05:35 UTC
The total of fines  already displays in the fines tab directly next to the checkouts on the circulation page. Maybe it could be made more visible instead?
Comment 2 Suzanne 2023-03-18 22:23:09 UTC
Fines related to rentals are not displayed for patrons, unless libraries choose to restrict patrons at the max fine rate. For example, we have a $10 limit for fines and our movies are $1-2 each. If a patron checks out $15 worth of rentals, we don't want them to have to stop and pay when they hit $10, so we are not restricting that, but what we found out is that by doing that, they don't ever see any rental related fees show up at all on the self check and staff weren't even seeing it on the checkout screen. (Some JavaScript has added it as a separate fee, but not to the total fines.) We would very much like to see this fixed.
Comment 3 Katrin Fischer 2023-04-16 11:00:38 UTC
Trying to make sure we have all information needed here:

* Is this about the patron account in staff interface, the patron account in OPAC or the self checkout display (web based/SIP2 based?)


For rentals and staff there is also an old bug here: bug 14803
Comment 4 Lari Strand 2023-09-08 11:23:01 UTC
Created attachment 155404 [details] [review]
Bug 33228 - Show all charges on the patron details and checkout page
Comment 5 Lari Strand 2023-09-08 11:43:36 UTC
Patch is for intranet only and only shows viewed patron's total charges (no possible guarantees accounted for).
Comment 6 Lari Strand 2023-09-08 12:55:03 UTC
Created attachment 155409 [details] [review]
Bug 33228 - Show all charges on the patron details and checkout page
Comment 7 Lari Strand 2023-09-08 13:13:19 UTC
Created attachment 155410 [details] [review]
Bug 33228 - Show all charges on the patron details and checkout page in intranet
Comment 8 Lari Strand 2023-09-08 13:17:44 UTC
Created attachment 155411 [details] [review]
Bug 33228 - Show all charges on the patron details and checkout page in intranet
Comment 9 Laura Escamilla 2023-10-11 11:46:39 UTC
Hi Lari, could you please include a test plan? Thank you!
Comment 10 Suzanne 2024-05-22 01:06:46 UTC
Just wondering if we could get some movement on this ticket, again. Thanks!
Comment 11 Nick Clemens (kidclamp) 2025-12-18 17:06:01 UTC
Created attachment 190628 [details] [review]
Bug 33228: Display all fines on patron details and circulation

This patch adds the patrons total balance to the details and circulation pages
Only showing totla if different from the no account charges

To test:
 1 - Go to Administration - Debit types
 2 - Add a new type:
    Code: BLOCK
    Description: Blocking fine
    Default amount: 1.00
    Can be manually invoiced: checked
    Included in noissuescharge: checked
 3 - Add a new type:
    Code: NoBLOCK
    Description: NonBlocking fine
    Default amount: 1.11
    Can be manually invoiced: checked
    Included in noissuescharge: checked
 4 - Find a patron
 5 - Accounting->Create manual invoice
 6 - Add 2 of each type of debit you created
 7 - View patrons 'details' and 'Check out' tabs
 8 - Confirm you see only the 2 blocking fees totaled
 9 - Apply patch
10 - Reload
11 - Confirm you see 'Total balance: 4.22'
     Charges: Patron has outstanding charges that may block checkout of 2.00.
12 - Write off the two non-block charges
13 - Confirm you no longer see the 'Total balance' (as it now matches)
14 - Write off the blocking charges and add two non-blocking
15 - Confirm you see the total balance
Comment 12 David Nind 2025-12-19 02:58:40 UTC
Created attachment 190643 [details] [review]
Bug 33228: Display all fines on patron details and circulation

This patch adds the patrons total balance to the details and circulation pages
Only showing total if different from the no account charges

To test:
 1 - Go to Administration - Debit types
 2 - Add a new type:
    Code: BLOCK
    Description: Blocking fine
    Default amount: 1.00
    Can be manually invoiced: checked
    Included in noissuescharge: checked
 3 - Add a new type:
    Code: NoBLOCK
    Description: NonBlocking fine
    Default amount: 1.11
    Can be manually invoiced: checked
    Included in noissuescharge: NOT checked
 4 - Find a patron
 5 - Accounting->Create manual invoice
 6 - Add 2 of each type of debit you created
 7 - View patrons 'details' and 'Check out' tabs
 8 - Confirm you see only the 2 blocking fees totaled
 9 - Apply patch
10 - Reload
11 - Confirm you see 'Total balance: 4.22'
     Charges: Patron has outstanding charges that may block checkout of 2.00.
12 - Write off the two non-block charges
13 - Confirm you no longer see the 'Total balance' (as it now matches)
14 - Write off the blocking charges and add two non-blocking
15 - Confirm you see the total balance

Signed-off-by: David Nind <david@davidnind.com>
Comment 13 David Nind 2025-12-19 03:10:48 UTC
I didn't see what is mentioned in the test plan.

I think for step 3, for the NoBLOCK debit type, the 'Included in noissuescharge:"  should be 'NOT checked' (instead of checked, as indicated).

If I do that, things work as detailed in the test plan.

That is:
- Before the patch 
     Charges: Patron has outstanding charges of 2.00. 
- After the patch: 
     Total balance: 4.22
     Charges: Patron has outstanding charges that may block checkouts of 2.00. 

I've amended the test plan and signed off on that basis.

If I got it wrong, please fix things up 8-).

Following the test
==================

Before the patch, for step 8:

1. On the patron's check out section I see:
    Cannot check out! 
    Attention
    Charges: Patron has outstanding charges of 4.22.

2. On the patron's details section I see:
    Attention
    Charges: Patron has outstanding charges of 4.22.

After the patch, I see:

1. On the patron's check out section I see:
    Cannot check out!
    Attention
      Total balance: 4.22
      Charges: Patron has outstanding charges that may block checkouts of 4.22. 

2. On the patron's details section I see:
    Attention
      Total balance: 4.22
      Charges: Patron has outstanding charges that may block checkouts of 4.22.
Comment 14 David Nind 2025-12-19 03:15:14 UTC
I didn't go through steps 12 to 15!

After steps 12 and 13, I still see 'Total balance' in the check out and details sections.

Changing status to Failed QA. 8-(..