| Summary: | [21.11] Advanced editor doesn't load | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alex Buckley <alexbuckley> |
| Component: | Cataloging | Assignee: | Alex Buckley <alexbuckley> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | arthur.suzuki, david, m.de.rooy, nick, paliotti |
| Version: | 21.11 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 31818 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33318: Fix JS errors on advanced cataloguing editor
Bug 33318: Fix JS errors on advanced cataloguing editor Bug 33318: Fix JS errors on advanced cataloguing editor |
||
|
Description
Alex Buckley
2023-03-23 05:44:14 UTC
Created attachment 148627 [details] [review] Bug 33318: Fix JS errors on advanced cataloguing editor This patch reverts bug 31818 Test plan: 1. Checkout 21.11.x 2. Set the EnableAdvancedCatalogingEditor syspref = 'Enable' 3. Go to Cataloguing > Advanced editor 4. Notice the advanced editor is stuck on 'Loading, please wait' 5. Right click > Inspect > Console 6. Notice there is a JS error: "Uncaught TypeError: $.fn.popover.Constructor.DEFAULTS.whiteList is undefined" 7. Apply patch 8. Restart services 9. Refresh the advanced editor 10. Notice it is not stuck on 'Loading, please wait' 11. Right click > Inspect > Console 12. Notice the JS error is no longer showing 13. Click on 'Keyboard shortcuts' and confirm it contains content - that is what bug 31818 was aiming to fix Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Ready for testing Created attachment 149732 [details] [review] Bug 33318: Fix JS errors on advanced cataloguing editor This patch reverts bug 31818 Test plan: 1. Checkout 21.11.x 2. Set the EnableAdvancedCatalogingEditor syspref = 'Enable' 3. Go to Cataloguing > Advanced editor 4. Notice the advanced editor is stuck on 'Loading, please wait' 5. Right click > Inspect > Console 6. Notice there is a JS error: "Uncaught TypeError: $.fn.popover.Constructor.DEFAULTS.whiteList is undefined" 7. Apply patch 8. Restart services 9. Refresh the advanced editor 10. Notice it is not stuck on 'Loading, please wait' 11. Right click > Inspect > Console 12. Notice the JS error is no longer showing 13. Click on 'Keyboard shortcuts' and confirm it contains content - that is what bug 31818 was aiming to fix Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD):
1. Edit .env and change KOHA_IMAGE=21.11
2. For your local git repository, checkout 21.11.x
3. To access the container,[1] ktd --root --shell
[1] If I didn't do this, and accessed as normal (ktd --shell), I couldn't apply the patch:
git bz apply 33318
Traceback (most recent call last):
File "/usr/bin/git-bz", line 2716, in <module>
applied = do_apply(bug_ref)
File "/usr/bin/git-bz", line 1738, in do_apply
attachmentdata=True)
File "/usr/bin/git-bz", line 1473, in load
bug._load(bug_reference.id, attachmentdata)
File "/usr/bin/git-bz", line 1229, in _load
response = self.server.send_request("GET", url)
File "/usr/bin/git-bz", line 999, in send_request
cookies = self.get_cookie_string()
File "/usr/bin/git-bz", line 992, in get_cookie_string
self.cookies = get_bugzilla_cookies(host)
NameError: global name 'host' is not defined
Created attachment 150385 [details] [review] Bug 33318: Fix JS errors on advanced cataloguing editor This patch reverts bug 31818 Test plan: 1. Checkout 21.11.x 2. Set the EnableAdvancedCatalogingEditor syspref = 'Enable' 3. Go to Cataloguing > Advanced editor 4. Notice the advanced editor is stuck on 'Loading, please wait' 5. Right click > Inspect > Console 6. Notice there is a JS error: "Uncaught TypeError: $.fn.popover.Constructor.DEFAULTS.whiteList is undefined" 7. Apply patch 8. Restart services 9. Refresh the advanced editor 10. Notice it is not stuck on 'Loading, please wait' 11. Right click > Inspect > Console 12. Notice the JS error is no longer showing 13. Click on 'Keyboard shortcuts' and confirm it contains content - that is what bug 31818 was aiming to fix Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Moved to oldoldstable queue for Arthur |