| Summary: | GET /biblios encoding wrong when UNIMARC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 32336, 32734 | ||
| Bug Blocks: | 32735 | ||
| Attachments: |
Bug 33329: Regression tests
Bug 33329: Correctly handle UNIMARC encoding for biblios Bug 33329: Regression tests Bug 33329: Correctly handle UNIMARC encoding for biblios Bug 33329: Regression tests Bug 33329: Correctly handle UNIMARC encoding for biblios |
||
|
Description
Tomás Cohen Arazi (tcohen)
2023-03-23 23:45:47 UTC
Created attachment 148629 [details] [review] Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! Hi, only submitted regression tests while waiting for my flight. Now is time to take off! See you soon! Created attachment 149708 [details] [review] Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Created attachment 149734 [details] [review] Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! Signed-off-by: David Nind <david@davidnind.com> Created attachment 149735 [details] [review] Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Created attachment 150375 [details] [review] Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 150376 [details] [review] Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Missing dependencies for 22.05.x, no backport. |