| Summary: | Show primary_contact_method when holds are triggered | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, dcook, gmcharlt, kyle.m.hall, kyle, Laura.escamilla |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/985 |
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 38138 | ||
| Attachments: |
Bug 33398: Add primary_contact_method to display when triggering a waiting hold
Bug 33398: Add primary_contact_method to display when triggering a waiting hold Bug 33398: Add primary_contact_method to display when triggering a waiting hold |
||
|
Description
Lucas Gass (lukeg)
2023-04-03 21:57:22 UTC
Hi Lucas, I am not sure if I understand this one. I think the idea of the display is to show if an email notification was sent out or not. The primary contact method from the patron record currently does have no effect and is only for display. Maybe it could be shown additionally instead of instead? (In reply to Katrin Fischer from comment #1) > Hi Lucas, > > I am not sure if I understand this one. > > I think the idea of the display is to show if an email notification was sent > out or not. The primary contact method from the patron record currently does > have no effect and is only for display. > > Maybe it could be shown additionally instead of instead? Showing it additionally would be fine with me. Changing the title of this bug to reflect that. Created attachment 149136 [details] [review] Bug 33398: Add primary_contact_method to display when triggering a waiting hold To test: 1. Apply patch, yarn build 2. Trigger a waiting hold for a patron that has a value for primary_contact_method 3. Notice the modal now includes a line indicating the primary_contact_method. 4. Trigger a hold for a patron without a primary_contact_method. Nothing should display. Created attachment 149202 [details] [review] Bug 33398: Add primary_contact_method to display when triggering a waiting hold To test: 1. Apply patch, yarn build 2. Trigger a waiting hold for a patron that has a value for primary_contact_method 3. Notice the modal now includes a line indicating the primary_contact_method. 4. Trigger a hold for a patron without a primary_contact_method. Nothing should display. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 150399 [details] [review] Bug 33398: Add primary_contact_method to display when triggering a waiting hold To test: 1. Apply patch, yarn build 2. Trigger a waiting hold for a patron that has a value for primary_contact_method 3. Notice the modal now includes a line indicating the primary_contact_method. 4. Trigger a hold for a patron without a primary_contact_method. Nothing should display. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement, no backport for 23.05.x |