Bug 33409

Summary:	Use template wrapper for breadcrumbs: Patrons lists
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	RESOLVED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	minor
Priority:	P5 - low	CC:	andrew.auld, testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.05
Circulation function:
Bug Depends on:	32507
Bug Blocks:	33454
Attachments:	Bug 33409: Use template wrapper for breadcrumbs: Patrons lists Bug 33409: Use template wrapper for breadcrumbs: Patrons lists Bug 33409: Use template wrapper for breadcrumbs: Patrons lists Bug 33409: Use template wrapper for breadcrumbs: Patrons lists

Description Owen Leonard 2023-04-04 15:27:01 UTC

To continue the process started by Bug 32507, this patch will update patron list templates so that they use the new template wrapper for breadcrumbs.

 - modules/patron_lists/add-modify.tt
 - modules/patron_lists/list.tt
 - modules/patron_lists/lists.tt

Comment 1 Owen Leonard 2023-04-04 15:43:57 UTC Comment hidden (obsolete)

Created attachment 149135 [details] [review]
Bug 33409: Use template wrapper for breadcrumbs: Patrons lists

This patch updates several patron templates so that they use the
new WRAPPER for displaying breadcrumbs.

Unrelated minor change: I added <span> around a few other strings in
add-modify.tt in order to improve translatability.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron lists
    - Main page
    - Patron list contents view
    - Add patron list
    - Edit patron list

Comment 2 Owen Leonard 2023-04-04 16:41:31 UTC

Created attachment 149137 [details] [review]
Bug 33409: Use template wrapper for breadcrumbs: Patrons lists

This patch updates several patron lists templates so that they use the
new WRAPPER for displaying breadcrumbs.

Unrelated minor change: I added <span> around a few other strings in
add-modify.tt in order to improve translatability.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron lists
    - Main page
    - Patron list contents view
    - Add patron list
    - Edit patron list

Comment 3 ByWater Sandboxes 2023-04-05 14:54:19 UTC

Created attachment 149216 [details] [review]
Bug 33409: Use template wrapper for breadcrumbs: Patrons lists

This patch updates several patron lists templates so that they use the
new WRAPPER for displaying breadcrumbs.

Unrelated minor change: I added <span> around a few other strings in
add-modify.tt in order to improve translatability.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron lists
    - Main page
    - Patron list contents view
    - Add patron list
    - Edit patron list

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>

Comment 4 Andrew Auld 2023-04-05 14:54:55 UTC

All works and looks as it should. :)

Comment 5 Katrin Fischer 2023-04-08 20:29:25 UTC

Created attachment 149303 [details] [review]
Bug 33409: Use template wrapper for breadcrumbs: Patrons lists

This patch updates several patron lists templates so that they use the
new WRAPPER for displaying breadcrumbs.

Unrelated minor change: I added <span> around a few other strings in
add-modify.tt in order to improve translatability.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Patron lists
    - Main page
    - Patron list contents view
    - Add patron list
    - Edit patron list

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 6 Tomás Cohen Arazi (tcohen) 2023-04-12 12:28:23 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 7 Jacob O'Mara 2023-04-16 20:38:43 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.