Bug 33454 - Improve breadcrumbs for patron lists
Summary: Improve breadcrumbs for patron lists
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Eric Garcia
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 33409
Blocks:
  Show dependency tree / graph
 
Reported: 2023-04-08 20:28 UTC by Katrin Fischer
Modified: 2025-01-10 02:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the breadcrumbs for patron lists (Tools > Patrons and circulation > Patron lists) so that they are now more consistent with other breadcrumbs, and improves their translatability (Tools > Patron lists > Add patrons to 'List name', instead of Tools > Patron lists > List name).
Version(s) released in:
25.05.00
Circulation function:

Attachments
Bug 33454: Improved breadcrumbs for patron lists (1.25 KB, patch)
2024-07-08 19:17 UTC, Eric Garcia 		Details | Diff | Splinter Review
Bug 33454: Improved breadcrumbs for patron lists (1.31 KB, patch)
2024-09-26 19:04 UTC, PTFS Europe Sandboxes 		Details | Diff | Splinter Review
Bug 33454: (follow-up) Use tx() to improve translatability (1.03 KB, patch)
2024-12-27 16:44 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-08 20:28:38 UTC 
When looking at a patron list, the breadcrumbs look like this:

Tools > Patron lists >  Test > Add patrons 

When you click on "Test", the name of the list, you get to the same page as "Add patrons". As that are not different pages, I think we should combine the crumbs:

Tools > Patron lists >  Add patrons to Test
Comment 1 Eric Garcia 2024-07-08 19:17:04 UTC 
Created attachment 168615 [details] [review]
Bug 33454: Improved breadcrumbs for patron lists

To test:
1. Apply patch
2. Tools -> Patron lists
3. Create a new patron list
4. Click on the name of your new list
5. Notice the breadcrumbs are changed to "Add patron to 'LIST NAME'"
6. Return to Patron lists
7. In your patron list select Actions -> Add patrons
8. Notice the breadcrumbs are the same
Comment 2 Michaela Sieber 2024-07-10 06:11:18 UTC 
This was already fixed in Main with bug Bug 34769 , see Github :
https://github.com/Koha-Community/Koha/commit/486f81be1013a8389a620bd14d3a29849038d455
Comment 3 PTFS Europe Sandboxes 2024-09-26 19:04:05 UTC 
Created attachment 172023 [details] [review]
Bug 33454: Improved breadcrumbs for patron lists

To test:
1. Apply patch
2. Tools -> Patron lists
3. Create a new patron list
4. Click on the name of your new list
5. Notice the breadcrumbs are changed to "Add patron to 'LIST NAME'"
6. Return to Patron lists
7. In your patron list select Actions -> Add patrons
8. Notice the breadcrumbs are the same

Signed-off-by: Fiona Borthwick <fiona.borthwick@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-12-27 16:24:38 UTC 
We should use something similar to this structure here to improve translatability:

[% tx("Modify patron list '{list_name}'", { list_name = list.name }) | html %]
Comment 5 Katrin Fischer 2024-12-27 16:44:55 UTC 
Created attachment 175960 [details] [review]
Bug 33454: (follow-up) Use tx() to improve translatability
Comment 6 Katrin Fischer 2024-12-27 16:45:16 UTC 
Wrote a follow-up for the noted translation issue.
Comment 7 Katrin Fischer 2024-12-27 16:46:43 UTC 
Pushed for 25.05!

Well done everyone, thank you!