Bug 33453

Summary:	Confirmation button for 'Record cashup' should be yellow
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Staff interface	Assignee:	Vicki <vicki.mckay>
Status:	Pushed to oldstable ---	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	minor
Priority:	P5 - low	CC:	aleisha, david, fridolin.somers, gmcharlt, lucas, martin.renvoize, vicki.mckay, wainuiwitikapark
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes the style of the "Confirm" button in the pop-up window when recording a cashup (Tools > Transaction history for > Record cashup). The button was changed from the default button style (with a white background) to the yellow primary action button.	Version(s) released in:	24.11.00,24.05.04,23.11.09
Circulation function:
Attachments:	Bug 33453: Change the button class of the record cashup modal to btn-primary Bug 33453: Change the button class of the record cashup modal to btn-primary Bug 33453: Change the button class of the record cashup modal to btn-primary Bug 33453: Change the button class of the record cashup modal to btn-primary

Description Katrin Fischer 2023-04-08 20:01:16 UTC

When recording a cashup the confirmation button in the modal should be 'yellow' for the primary action.

* Enable cash registers and create a cash register
* Go to Tools > Transaction history for ...
* Click on 'Record cashup'

Comment 1 Koha Training Catalyst 2024-07-25 22:29:50 UTC

Created attachment 169617 [details] [review]
Bug 33453: Change the button class of the record cashup modal to btn-primary

To test:

1. Go to System Preferences > find and enable "Use cash registers"
2. Go to Administration > "Cash registers" and create a new cash register
3. Go to Tools > "Transaction history for" > "Record cashup"
4. Click "Record cashup"
5. Modal with change: "Confirm" should be yellow and primary.

Comment 2 Koha Training Catalyst 2024-07-25 22:53:56 UTC

Created attachment 169621 [details] [review]
Bug 33453: Change the button class of the record cashup modal to btn-primary

To test:

1. Go to System Preferences > find and enable "Use cash registers"
2. Go to Administration > "Cash registers" and create a new cash register
3. Go to Tools > "Transaction history for" > "Record cashup"
4. Click "Record cashup"
5. Modal with change: "Confirm" should be yellow and primary.

Comment 3 David Nind 2024-07-26 05:46:41 UTC

Created attachment 169641 [details] [review]
Bug 33453: Change the button class of the record cashup modal to btn-primary

To test:

1. Go to System Preferences > find and enable "Use cash registers"
2. Go to Administration > "Cash registers" and create a new cash register
3. Go to Tools > "Transaction history for" > "Record cashup"
4. Click "Record cashup"
5. Modal with change: "Confirm" should be yellow and primary.

Signed-off-by: David Nind <david@davidnind.com>

Comment 4 David Nind 2024-07-26 05:54:21 UTC

Hi.

I have added a release note.

I also changed the bug from an enhancement to a minor bug, as it is something inconsistent with the rest of the UI that requires fixing.

Everything works as expected - nice work!

To get credit on the dashboard (https://dashboard.koha-community.org/), and to be listed as a Koha developer on the Koha timeline page, please update the assignee for the bug.

David Nind

Comment 5 Martin Renvoize (ashimema) 2024-07-26 14:00:03 UTC

Whilst the code here is good, I'd really like to see accountability in the author of the patch.. we shouldn't be sharing accounts for authoring commits.. Please correct the patch by adding a proper author to it.

Comment 6 Aleisha Amohia 2024-07-30 01:34:32 UTC

Hi Martin

This was for a 2 hour bug squashing session. I'll contact the author to change the Assignee on the bug report. It's not a regular occurrence that we're sharing authorship.

If the code is fine can we please set this back to Signed Off?

Comment 7 Vicki 2024-07-30 02:52:06 UTC

Sorry Martin!

Aleisha did remind me to do this, and then I forgot :)

Was a pleasure to participate in some Koha development for the first time.

Comment 8 Katrin Fischer 2024-07-30 07:33:39 UTC

(In reply to Vicki from comment #7)
> Sorry Martin!
> 
> Aleisha did remind me to do this, and then I forgot :)
> 
> Was a pleasure to participate in some Koha development for the first time.

Hi Vicky, 

if you let me know which name you want to appear and if this email address is ok to use, I can update the patch file for you with that information to move it back into the queue.

Thanks for participating and providing a patch!

Comment 9 Martin Renvoize (ashimema) 2024-08-01 11:16:06 UTC

Created attachment 169940 [details] [review]
Bug 33453: Change the button class of the record cashup modal to btn-primary

To test:

1. Go to System Preferences > find and enable "Use cash registers"
2. Go to Administration > "Cash registers" and create a new cash register
3. Go to Tools > "Transaction history for" > "Record cashup"
4. Click "Record cashup"
5. Modal with change: "Confirm" should be yellow and primary.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 10 Martin Renvoize (ashimema) 2024-08-01 11:17:06 UTC

Thanks Vicki (and Aliesha for organising the bug squashing event),

I've amended the patch and passed it now, many thanks

Martin

Comment 11 Katrin Fischer 2024-08-01 16:27:10 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 12 Katrin Fischer 2024-08-01 16:28:36 UTC

Congratulations Vicki, you are now officially a Koha developer :)

Comment 13 Lucas Gass (lukeg) 2024-08-29 17:40:45 UTC

Backported to 24.05.x for upcoming 24.05.04

Comment 14 Fridolin Somers 2024-09-17 13:44:37 UTC

Pushed to 23.11.x for 23.11.09

Comment 15 Wainui Witika-Park 2024-09-18 06:44:37 UTC

Not backporting to 23.05.x unless requested