Summary: | Improve breadcrumbs for patron lists | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Patrons | Assignee: | Eric Garcia <cubingguy714> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | cubingguy714, david, fiona.borthwick, gmcharlt, kyle.m.hall, michaela.sieber |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34769 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the breadcrumbs for patron lists (Tools > Patrons and circulation > Patron lists) so that they are now more consistent with other breadcrumbs, and improves their translatability (Tools > Patron lists > Add patrons to 'List name', instead of Tools > Patron lists > List name).
|
Version(s) released in: |
25.05.00
|
Circulation function: | |||
Bug Depends on: | 33409 | ||
Bug Blocks: | |||
Attachments: |
Bug 33454: Improved breadcrumbs for patron lists
Bug 33454: Improved breadcrumbs for patron lists Bug 33454: (follow-up) Use tx() to improve translatability |
Description
Katrin Fischer
2023-04-08 20:28:38 UTC
Created attachment 168615 [details] [review] Bug 33454: Improved breadcrumbs for patron lists To test: 1. Apply patch 2. Tools -> Patron lists 3. Create a new patron list 4. Click on the name of your new list 5. Notice the breadcrumbs are changed to "Add patron to 'LIST NAME'" 6. Return to Patron lists 7. In your patron list select Actions -> Add patrons 8. Notice the breadcrumbs are the same This was already fixed in Main with bug Bug 34769 , see Github : https://github.com/Koha-Community/Koha/commit/486f81be1013a8389a620bd14d3a29849038d455 Created attachment 172023 [details] [review] Bug 33454: Improved breadcrumbs for patron lists To test: 1. Apply patch 2. Tools -> Patron lists 3. Create a new patron list 4. Click on the name of your new list 5. Notice the breadcrumbs are changed to "Add patron to 'LIST NAME'" 6. Return to Patron lists 7. In your patron list select Actions -> Add patrons 8. Notice the breadcrumbs are the same Signed-off-by: Fiona Borthwick <fiona.borthwick@ptfs-europe.com> We should use something similar to this structure here to improve translatability: [% tx("Modify patron list '{list_name}'", { list_name = list.name }) | html %] Created attachment 175960 [details] [review] Bug 33454: (follow-up) Use tx() to improve translatability Wrote a follow-up for the noted translation issue. Pushed for 25.05! Well done everyone, thank you! |