| Summary: | Heading on 'update password' page is too big | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Staff interface | Assignee: | Sam Lewis <samlewis> |
| Status: | Pushed to oldstable --- | QA Contact: | Matt Blenkinsop <matt.blenkinsop> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, lucas, matt.blenkinsop, samlewis, wainuiwitikapark |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the heading for the patron change password page in the staff interface (Patrons > search for a patron > Change password). It was previously part of the form area with the white background, when it should have been above it like other page headings.
|
Version(s) released in: |
24.11.00,24.05.04,23.11.09
|
| Circulation function: | |||
| Attachments: |
Bug 33455: The h1 heading on the change passwordpage is too big and should be outside of the legend.
Bug 33455: Fix the size of the patron change password heading Bug 33455: Fix the size of the patron change password heading |
||
|
Description
Katrin Fischer
2023-04-08 20:36:20 UTC
Created attachment 169626 [details] [review] Bug 33455: The h1 heading on the change passwordpage is too big and should be outside of the legend. Test Plan 1. Click on top right of menu and navigate to my account 2. Navigate to Change Password 3. Observe that title is outside the legend and font size is comparable to other H1 headings (e.g. Duplicate). Created attachment 169634 [details] [review] Bug 33455: Fix the size of the patron change password heading The H1 heading on the patron change password page in the staff interface is too big and should be outside of the area with form area with the white background. Test plan: 1. In the staff interface, click on top right of menu and navigate to my account. 2. Click the 'Change password' button. 3. Note that title is now outside the legend and font size is comparable to other H1 headings (e.g. Duplicate). Signed-off-by: David Nind <david@davidnind.com> Hi. I have updated the commit message and added a release note. I also changed the bug from an enhancement to a normal bug, as it is something inconsistent with the rest of the UI that requires fixing. Everything works as expected - nice work! To get credit on the dashboard (https://dashboard.koha-community.org/), and to be listed as a Koha developer on the Koha timeline page, please update the assignee for the bug. David Nind Created attachment 169689 [details] [review] Bug 33455: Fix the size of the patron change password heading The H1 heading on the patron change password page in the staff interface is too big and should be outside of the area with form area with the white background. Test plan: 1. In the staff interface, click on top right of menu and navigate to my account. 2. Click the 'Change password' button. 3. Note that title is now outside the legend and font size is comparable to other H1 headings (e.g. Duplicate). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.04 Pushed to 23.11.x for 23.11.09 Not backporting to 23.05.x unless requested |