Summary: | Add 'host_items' param to Koha::Biblio->items | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, m.de.rooy, martin.renvoize, matt.blenkinsop |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 37964, 33497 | ||
Attachments: |
Bug 33496: Add 'host_items' param to Koha::Biblio->items
Bug 33496: Add 'host_items' param to Koha::Biblio->items Bug 33496: (follow-up) Correct param names Bug 33496: Add 'host_items' param to Koha::Biblio->items Bug 33496: (follow-up) Correct param names Bug 33496: (QA follow-up) Update POD statement |
Description
Nick Clemens (kidclamp)
2023-04-11 18:40:05 UTC
Created attachment 149465 [details] [review] Bug 33496: Add 'host_items' param to Koha::Biblio->items This patch adds an option to the $biblio->items method to allow retrieving the items and analytic items for a record. This is intended to allow fetching a single Items object, and related object, rather than having to fetch the items, and the host items, and push them together This is step towards being able to fetch items using API/DataTables directly To test: 1 - prove -v t/db_dependent/Koha/Biblio.t Added assignee. Created attachment 149572 [details] [review] Bug 33496: Add 'host_items' param to Koha::Biblio->items This patch adds an option to the $biblio->items method to allow retrieving the items and analytic items for a record. This is intended to allow fetching a single Items object, and related object, rather than having to fetch the items, and the host items, and push them together This is step towards being able to fetch items using API/DataTables directly To test: 1 - prove -v t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind <david@davidnind.com> FAIL Koha/Biblio.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling FAIL valid "my" variable $params masks earlier declaration in same scope "my" variable $params masks earlier declaration in same scope FAIL t/db_dependent/Koha/Biblio.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling FAIL valid "my" variable $params masks earlier declaration in same scope Created attachment 149678 [details] [review] Bug 33496: (follow-up) Correct param names Marking as enhancement. Created attachment 151466 [details] [review] Bug 33496: Add 'host_items' param to Koha::Biblio->items This patch adds an option to the $biblio->items method to allow retrieving the items and analytic items for a record. This is intended to allow fetching a single Items object, and related object, rather than having to fetch the items, and the host items, and push them together This is step towards being able to fetch items using API/DataTables directly To test: 1 - prove -v t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 151467 [details] [review] Bug 33496: (follow-up) Correct param names Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 151468 [details] [review] Bug 33496: (QA follow-up) Update POD statement Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x Backport to 22.11.x reverted - a missing dependency in the tree (33167) has been identified |