Bug 33496 - Add 'host_items' param to Koha::Biblio->items
Summary: Add 'host_items' param to Koha::Biblio->items
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Nick Clemens
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 33497
  Show dependency treegraph
 
Reported: 2023-04-11 18:40 UTC by Nick Clemens
Modified: 2023-07-19 09:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02


Attachments
Bug 33496: Add 'host_items' param to Koha::Biblio->items (3.80 KB, patch)
2023-04-11 18:50 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33496: Add 'host_items' param to Koha::Biblio->items (3.85 KB, patch)
2023-04-12 17:43 UTC, David Nind
Details | Diff | Splinter Review
Bug 33496: (follow-up) Correct param names (1.02 KB, patch)
2023-04-14 12:47 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33496: Add 'host_items' param to Koha::Biblio->items (3.95 KB, patch)
2023-05-19 09:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33496: (follow-up) Correct param names (1.12 KB, patch)
2023-05-19 09:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33496: (QA follow-up) Update POD statement (808 bytes, patch)
2023-05-19 09:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-04-11 18:40:05 UTC
This patch will add an option to the $biblio->items method to allow
retrieving the items and analytic items for a record. This is intended
to allow fetching a single Items object, and related object, rather than
having to fetch the items, and the host items, and push them together
Comment 1 Nick Clemens 2023-04-11 18:50:42 UTC
Created attachment 149465 [details] [review]
Bug 33496: Add 'host_items' param to Koha::Biblio->items

This patch adds an option to the $biblio->items method to allow
retrieving the items and analytic items for a record. This is intended
to allow fetching a single Items object, and related object, rather than
having to fetch the items, and the host items, and push them together

This is step towards being able to fetch items using API/DataTables directly

To test:
1 - prove -v t/db_dependent/Koha/Biblio.t
Comment 2 David Nind 2023-04-11 19:11:14 UTC
Added assignee.
Comment 3 David Nind 2023-04-12 17:43:54 UTC
Created attachment 149572 [details] [review]
Bug 33496: Add 'host_items' param to Koha::Biblio->items

This patch adds an option to the $biblio->items method to allow
retrieving the items and analytic items for a record. This is intended
to allow fetching a single Items object, and related object, rather than
having to fetch the items, and the host items, and push them together

This is step towards being able to fetch items using API/DataTables directly

To test:
1 - prove -v t/db_dependent/Koha/Biblio.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Marcel de Rooy 2023-04-14 07:20:44 UTC
 FAIL   Koha/Biblio.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   FAIL   valid
                "my" variable $params masks earlier declaration in same scope
                "my" variable $params masks earlier declaration in same scope

 FAIL   t/db_dependent/Koha/Biblio.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   FAIL   valid
                "my" variable $params masks earlier declaration in same scope
Comment 5 Nick Clemens 2023-04-14 12:47:35 UTC
Created attachment 149678 [details] [review]
Bug 33496: (follow-up) Correct param names
Comment 6 Marcel de Rooy 2023-05-12 08:48:11 UTC
Marking as enhancement.
Comment 7 Marcel de Rooy 2023-05-19 09:59:53 UTC
Created attachment 151466 [details] [review]
Bug 33496: Add 'host_items' param to Koha::Biblio->items

This patch adds an option to the $biblio->items method to allow
retrieving the items and analytic items for a record. This is intended
to allow fetching a single Items object, and related object, rather than
having to fetch the items, and the host items, and push them together

This is step towards being able to fetch items using API/DataTables directly

To test:
1 - prove -v t/db_dependent/Koha/Biblio.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2023-05-19 09:59:55 UTC
Created attachment 151467 [details] [review]
Bug 33496: (follow-up) Correct param names

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2023-05-19 09:59:57 UTC
Created attachment 151468 [details] [review]
Bug 33496: (QA follow-up) Update POD statement

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Tomás Cohen Arazi 2023-07-06 13:10:32 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Martin Renvoize 2023-07-17 15:44:45 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 12 Matt Blenkinsop 2023-07-18 13:28:16 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 13 Matt Blenkinsop 2023-07-19 09:54:26 UTC
Backport to 22.11.x reverted - a missing dependency in the tree (33167) has been identified