Summary: | Make interface URL clickable on vendor details | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00
|
Circulation function: | |
Bug Depends on: | 33104 | ||
Bug Blocks: | |||
Attachments: |
Bug 33499: Make interface URL clickable on vendor details
Bug 33499: Make interface URL clickable on vendor details Bug 33499: Make interface URL clickable on vendor details Bug 33499: (QA follow-up) Open external links in new tab |
Description
Katrin Fischer
2023-04-11 21:10:23 UTC
Could we also add an hyperlink for the vendor interface URI? I was expecting to be able to click on it, but it's not a link, so I have to copy/paste it in my browser. https://snipboard.io/IsYrAF.jpg I think some of this has been resolved since on another bug, I'll make it about the URL :) Created attachment 155889 [details] [review] Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. Created attachment 155895 [details] [review] Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 155912 [details] [review] Bug 33499: Make interface URL clickable on vendor details This patch adds markup around the vendor details interface URL so that it is a clickable link. To test, apply the patch and go to Acquisitions. - Search for a vendor - If you don't have a vendor with interfaces defined, edit one - Under Interfaces -> Interface details, fill out the form, including the URI field. - Add more than one interface - Save your changes and then view the vendor details page - In the Interfaces section the interfaces you defined should have clickable links. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 155913 [details] [review] Bug 33499: (QA follow-up) Open external links in new tab Adds target="_blank" to the vendor website and interface URLs, as we can expect them to be external sites. Also changes mark-up a little so that the URL is shown without an additional space in front, lining up with the other fields. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! |