| Summary: | Show 'Document type' in list of suggestions when creating an order from a suggestion | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | Needs documenting --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, jheltibridle, jonathan.druart, matt.blenkinsop |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33326 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
The 'Document type' of a suggestion will now be visible in the list of accepted suggestions when creating a new order line. This is to help with ordering the right material type and also for picking the correct item type.
|
Version(s) released in: |
23.05.00
|
| Circulation function: | |||
| Attachments: |
Bug 33541: Add document type to list of suggestions when ordering
Bug 33541: Add document type to list of suggestions when ordering Bug 33541: Add document type to list of suggestions when ordering Bug 33541: Add document type to list of suggestions when ordering |
||
|
Description
Katrin Fischer
2023-04-16 13:59:51 UTC
Created attachment 149730 [details] [review] Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Created attachment 149731 [details] [review] Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle@rcplib.org> That was fast! Thank you, Juliet! Hi Juliet. If you could edit status to change it to 'Signed off', that would be great! This will give you credit for the sign off in the dashboard - it will then show under Signoffs - April (https://dashboard.koha-community.org/). David This table can be configured, you need to update admin/columns_settings.yml Also you don't need the third parameter (opac=0), it's the default value. Created attachment 150554 [details] [review] Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle@rcplib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Removed IS_OPAC param from AuthorisedValues.GetByCode (In reply to Jonathan Druart from comment #5) > This table can be configured, you need to update admin/columns_settings.yml I think you are confusing the tables. suggestions is, but newordersuggestion is not configurable. This is the table with accepted suggestions shown when using "ordering from suggestion". It has no table configuration icons and I didn't find it in the config. > Also you don't need the third parameter (opac=0), it's the default value. Fixed. Created attachment 150562 [details] [review] Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle@rcplib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Removed IS_OPAC param from AuthorisedValues.GetByCode Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Katrin Fischer from comment #7) > (In reply to Jonathan Druart from comment #5) > > This table can be configured, you need to update admin/columns_settings.yml > > I think you are confusing the tables. suggestions is, but newordersuggestion > is not configurable. This is the table with accepted suggestions shown when > using "ordering from suggestion". It has no table configuration icons and I > didn't find it in the config. Indeed, I was looking at the wrong table! Pushed to master for 23.05. Nice work everyone, thanks! Enhancement - not backporting to 22.11.x |