Summary: | Batch edit link broken if subscriptions are selected using "select all" link | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Serials | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06
|
|
Circulation function: | |||
Bug Depends on: | 32698 | ||
Bug Blocks: | 33559 | ||
Attachments: |
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link |
Description
Owen Leonard
2023-04-18 16:50:29 UTC
Created attachment 149895 [details] [review] Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Created attachment 150112 [details] [review] Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david@davidnind.com> Created attachment 150117 [details] [review] Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Not needed in 22.05.x, no backport. |