Bug 32698 - Use template wrapper for serials pages tabs
Summary: Use template wrapper for serials pages tabs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks: 33560
  Show dependency treegraph
 
Reported: 2023-01-23 12:44 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32698: Use template wrapper for serials pages tabs (37.25 KB, patch)
2023-01-23 15:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32698: Use template wrapper for serials pages tabs (37.25 KB, patch)
2023-01-31 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32698: Use template wrapper for serials pages tabs (37.29 KB, patch)
2023-02-02 22:20 UTC, David Nind
Details | Diff | Splinter Review
Bug 32698: Use template wrapper for serials pages tabs (37.35 KB, patch)
2023-02-05 12:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-23 12:44:52 UTC
Continuing the work of Bug 32571, serials pages should be updated to use the new WRAPPER for tabs:

- Serial collection
- Serials search
- Subscription details
Comment 1 Owen Leonard 2023-01-23 15:14:38 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-01-28 20:01:46 UTC
The patch no longer applies 8-(..

git bz apply 32698

Bug 32698 Depends on bug 32571 (Signed Off)
Follow? [(y)es, (n)o] y

Bug 32571 - Use template wrapper to build tabbed components

145529 - Bug 32571: Use template wrapper to build tabbed components
145530 - Bug 32571: (follow-up) Implement abstracted tabs on About page
145533 - Bug 32571: (follow-up) Use more unique variable name to avoid collisions

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 32571: Use template wrapper to build tabbed components
Applying: Bug 32571: (follow-up) Implement abstracted tabs on About page
Applying: Bug 32571: (follow-up) Use more unique variable name to avoid collisions

Bug 32698 - Use template wrapper for serials pages tabs

145576 - Bug 32698: Use template wrapper for serials pages tabs

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 32698: Use template wrapper for serials pages tabs
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 32698: Use template wrapper for serials pages tabs
Comment 3 Owen Leonard 2023-01-31 14:43:01 UTC Comment hidden (obsolete)
Comment 4 David Nind 2023-02-02 22:20:41 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2023-02-05 12:51:28 UTC
Created attachment 146208 [details] [review]
Bug 32698: Use template wrapper for serials pages tabs

This patch updates three serials templates to replace tab markup with
the use of WRAPPERs.

To test requires more data than will be found in the sample data. You
need at least one subscription with issues spanning more than one year.
I suggest creating a new subscription which starts in December, then
receive one issue from December and one in January.

Apply the patch and go to Serials.

- Perform a subscription search.
  - On the search results page there should be two tabs: "Open" and
    "Closed." These tabs should work correctly.
- Open the detail view of one of your subscriptions.
  - You should see at least four tabs: "Information," "Planning,"
    "Issues," and "Summary."
  - In some cases an "Acquisition details" tab will also appear. To test
    this you must go to Acquisitions and add an order to a basket by
    choosing "From a subscription" option.
- Click "Serial collection" in the left-hand sidebar.
  - There should be tabs for each year of subscription issues in your
    collection.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-02-07 18:30:04 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-02-08 16:53:40 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.