Summary: | Holds queue is not selecting items with completed transfers | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | critical | ||
Priority: | P5 - low | CC: | acampbell, gmcharlt, jonathan.druart, Laura.escamilla, martin.renvoize, sophie.meynieux |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.05.00,22.11.07
|
Circulation function: | |
Bug Depends on: | 24295 | ||
Bug Blocks: | |||
Attachments: |
Bug 33761: Unit test
Bug 33761: Alter query to remove items with active transfers from available list Bug 33761: Unit test Bug 33761: Alter query to remove items with active transfers from available list |
Description
Nick Clemens (kidclamp)
2023-05-18 11:06:32 UTC
Created attachment 151386 [details] [review] Bug 33761: Unit test Created attachment 151387 [details] [review] Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success! Created attachment 151413 [details] [review] Bug 33761: Unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 151414 [details] [review] Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks for the prompt fix here Nick. Tested and working.. kinda silly I missed it until now. Signing off As this is critical.. lets go straight for PQA here.. It's a clear and simple fix with solid unit tests. Passing QA Pushed to master for 23.05. Nice work everyone, thanks! Can this be backported to 22.11.x? Nice work everyone! Pushed to stable for 22.11.x what is the value of x please ? for 22.11 Found, thanks |