Summary: | Markup errors on orderreceive.tt after 8179 | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Acquisitions | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | matt.blenkinsop, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00
|
|
Circulation function: | |||
Bug Depends on: | 8179 | ||
Bug Blocks: | |||
Attachments: |
Bug 33771: Fix markup errors in orderreceive.tt
Bug 33771: Fix markup errors in orderreceive.tt |
Description
Lucas Gass (lukeg)
2023-05-18 16:08:59 UTC
Created attachment 151429 [details] [review] Bug 33771: Fix markup errors in orderreceive.tt This patch fixed the following on orderreceive.tt: -One of the <th> is closed with a </td> -The #jobpanel element div is not properly closed -Style tags are in the HTML body and they should be in the HTML head -The #modal-order-main needs a class of 'row', this has been added. Apply the pacth and follow the steps in 8179 until you get to the orderreceive.tt. There should be no visual changes but the markup has been corrected. Created attachment 151430 [details] [review] Bug 33771: Fix markup errors in orderreceive.tt This patch fixed the following on orderreceive.tt: -One of the <th> is closed with a </td> -The #jobpanel element div is not properly closed -Style tags are in the HTML body and they should be in the HTML head -The #modal-order-main needs a class of 'row', this has been added. Apply the pacth and follow the steps in 8179 until you get to the orderreceive.tt. There should be no visual changes but the markup has been corrected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Dependency missing - not backporting to 22.11.x |