Bug 33771 - Markup errors on orderreceive.tt after 8179
Summary: Markup errors on orderreceive.tt after 8179
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 8179
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-18 16:08 UTC by Lucas Gass
Modified: 2023-06-08 16:55 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 33771: Fix markup errors in orderreceive.tt (5.04 KB, patch)
2023-05-18 16:12 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33771: Fix markup errors in orderreceive.tt (5.09 KB, patch)
2023-05-18 17:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-05-18 16:08:59 UTC
I am opening this bug to address so HTML markup errors on orderreceive.tt.

-One of the <th> is closed with a </td>
-The #jobpanel element div is not properly closed 
-Style tags are in the HTML body and they should be in the HTML head 
-The following is invalid

-                    <div id="modal-order-main row">


It should be:

+                    <div id="modal-order-main" class="row">
Comment 1 Lucas Gass 2023-05-18 16:12:58 UTC
Created attachment 151429 [details] [review]
Bug 33771: Fix markup errors in orderreceive.tt

This patch fixed the following on orderreceive.tt:

-One of the <th> is closed with a </td>
-The #jobpanel element div is not properly closed
-Style tags are in the HTML body and they should be in the HTML head
-The #modal-order-main needs a class of 'row', this has been added.

Apply the pacth and follow the steps in 8179 until you get to the orderreceive.tt. There should be no visual changes but the markup has been corrected.
Comment 2 Tomás Cohen Arazi 2023-05-18 17:14:08 UTC
Created attachment 151430 [details] [review]
Bug 33771: Fix markup errors in orderreceive.tt

This patch fixed the following on orderreceive.tt:

-One of the <th> is closed with a </td>
-The #jobpanel element div is not properly closed
-Style tags are in the HTML body and they should be in the HTML head
-The #modal-order-main needs a class of 'row', this has been added.

Apply the pacth and follow the steps in 8179 until you get to the orderreceive.tt. There should be no visual changes but the markup has been corrected.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2023-05-18 17:17:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 4 Matt Blenkinsop 2023-06-08 16:55:22 UTC
Dependency missing - not backporting to 22.11.x