| Summary: | reserves_stats.pl ignores filled holds without itemnumber | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Reports | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.07
|
|
| Circulation function: | |||
| Attachments: |
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect |
||
|
Description
Marcel de Rooy
2023-05-22 11:50:37 UTC
Actually, it is caused by looking at homebranch/holdingbranch in the where: items.homebranch LIKE ? AND items.holdingbranch LIKE ? And since there is no item, there is no branch.. And as mentioned on bug 23059, you can deselect that filter. But it does not work very intuitive. Created attachment 151518 [details] [review] Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect This preselect cuts off all next available holds that are in reserves, as well as holds filled by checkout without confirm (see 33791). Test plan: Go to reporting. Click Hold statistics. Verify that Holding library and Home library are not selected. Test that you can still filter by one of those. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 151531 [details] [review] Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect This preselect cuts off all next available holds that are in reserves, as well as holds filled by checkout without confirm (see 33791). Test plan: Go to reporting. Click Hold statistics. Verify that Holding library and Home library are not selected. Test that you can still filter by one of those. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 151557 [details] [review] Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect This preselect cuts off all next available holds that are in reserves, as well as holds filled by checkout without confirm (see 33791). Test plan: Go to reporting. Click Hold statistics. Verify that Holding library and Home library are not selected. Test that you can still filter by one of those. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |