Bug 33808

Summary: Accessibility: Non-descriptive links
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: OPACAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: RESOLVED FIXED QA Contact: Kyle M Hall (khall) <kyle>
Severity: enhancement    
Priority: P5 - low CC: kyle, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08,22.05.16
Circulation function:
Bug Depends on:    
Bug Blocks: 23003    
Attachments: Bug 33808: Add aria-labels in opac-shelves.tt
Bug 33808: Add aria-labels in opac-basket.tt
Bug 33808: Add aria-labels in basket.tt
Bug 33808: Add aria-labels in reports-toolbar.inc
Bug 33808: Add aria-labels in opac-shelves.tt
Bug 33808: Add aria-labels in opac-basket.tt
Bug 33808: Add aria-labels in basket.tt
Bug 33808: Add aria-labels in reports-toolbar.inc
Bug 33808: Add aria-labels in reports-toolbar.inc
Bug 33808: Add aria-labels in opac-shelves.tt
Bug 33808: Add aria-labels in opac-basket.tt
Bug 33808: Add aria-labels in basket.tt
Bug 33808: Add aria-labels in reports-toolbar.inc

Description Matt Blenkinsop 2023-05-23 13:56:52 UTC
An accessibility report run by the Shaw trust for the British Museum has found some examples of links that are not labelled descriptively enough for screen readers. Extract below: 

"The text of a link should describe the destination of the link and the link’s purpose. Providing a
descriptive link text will allow users to easily determine the function of the link and make educated
decisions to click the link or not.
If it is not possible to identify the purpose of the link from the link text itself, then this information
should be provided in context.
Screen reader users have the ability to display and navigate by lists of elements, or jump from
element to element. Navigating this way is much quicker than listening to a whole page, however
the context provided by paragraphs and other narrative is lost and non-descriptive links become
harder to understand.
For downloadable links, we recommend that the file type and size of the file is also included in the
link text to allow the user to make a decision whether or not to download the file.
On the 'opac-shelves.pl?op=view&shelfnumber=148&sortfield=title’ page there is a non-descriptive
link labelled ‘Download’, this issue is found on numerous pages tested."

This patch addresses similar Download buttons, adding aria-labels and aria-has popups to the links.
Comment 1 Matt Blenkinsop 2023-05-23 13:59:46 UTC Comment hidden (obsolete)
Comment 2 Matt Blenkinsop 2023-05-23 14:00:41 UTC Comment hidden (obsolete)
Comment 3 Matt Blenkinsop 2023-05-23 14:01:32 UTC Comment hidden (obsolete)
Comment 4 Matt Blenkinsop 2023-05-23 14:02:18 UTC
Created attachment 151567 [details] [review]
Bug 33808: Add aria-labels in reports-toolbar.inc

This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing
Comment 5 Owen Leonard 2023-05-23 16:57:53 UTC
Created attachment 151597 [details] [review]
Bug 33808: Add aria-labels in opac-shelves.tt

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2023-05-23 16:57:56 UTC
Created attachment 151598 [details] [review]
Bug 33808: Add aria-labels in opac-basket.tt

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2023-05-23 16:57:58 UTC
Created attachment 151599 [details] [review]
Bug 33808: Add aria-labels in basket.tt

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Owen Leonard 2023-05-23 16:59:28 UTC
> Bug 33808: Add aria-labels in reports-toolbar.inc

The label on this one, "Select format and download chart" is incorrect. It should be something like "Select format and download report results."
Comment 9 Matt Blenkinsop 2023-05-24 09:24:42 UTC
Created attachment 151617 [details] [review]
Bug 33808: Add aria-labels in reports-toolbar.inc

This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing
Comment 10 Matt Blenkinsop 2023-05-24 09:25:22 UTC
Thanks Owen, I've updated the patch as suggested :)
Comment 11 Owen Leonard 2023-05-24 10:46:33 UTC
Created attachment 151621 [details] [review]
Bug 33808: Add aria-labels in reports-toolbar.inc

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Kyle M Hall (khall) 2023-07-14 18:01:53 UTC
Created attachment 153495 [details] [review]
Bug 33808: Add aria-labels in opac-shelves.tt

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 13 Kyle M Hall (khall) 2023-07-14 18:01:59 UTC
Created attachment 153496 [details] [review]
Bug 33808: Add aria-labels in opac-basket.tt

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 14 Kyle M Hall (khall) 2023-07-14 18:02:01 UTC
Created attachment 153497 [details] [review]
Bug 33808: Add aria-labels in basket.tt

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 15 Kyle M Hall (khall) 2023-07-14 18:02:03 UTC
Created attachment 153498 [details] [review]
Bug 33808: Add aria-labels in reports-toolbar.inc

This patch adds an aria-label and an aria-haspopup to Download buttons
identified as non-descriptive in accessibility testing

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 16 Tomás Cohen Arazi (tcohen) 2023-07-14 18:24:04 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Martin Renvoize (ashimema) 2023-07-18 11:52:05 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 18 Matt Blenkinsop 2023-07-18 14:48:10 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 19 Lucas Gass 2023-09-13 19:51:42 UTC
Backported to 22.05.x for upcoming 22.05.16