|
Description
Matt Blenkinsop
2023-05-23 13:56:52 UTC
Created attachment 151564 [details] [review] Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Created attachment 151565 [details] [review] Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Created attachment 151566 [details] [review] Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Created attachment 151567 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Created attachment 151597 [details] [review] Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 151598 [details] [review] Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 151599 [details] [review] Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> > Bug 33808: Add aria-labels in reports-toolbar.inc
The label on this one, "Select format and download chart" is incorrect. It should be something like "Select format and download report results."
Created attachment 151617 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Thanks Owen, I've updated the patch as suggested :) Created attachment 151621 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 153495 [details] [review] Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 153496 [details] [review] Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 153497 [details] [review] Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 153498 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x Backported to 22.05.x for upcoming 22.05.16 |