An accessibility report run by the Shaw trust for the British Museum has found some examples of links that are not labelled descriptively enough for screen readers. Extract below: "The text of a link should describe the destination of the link and the link’s purpose. Providing a descriptive link text will allow users to easily determine the function of the link and make educated decisions to click the link or not. If it is not possible to identify the purpose of the link from the link text itself, then this information should be provided in context. Screen reader users have the ability to display and navigate by lists of elements, or jump from element to element. Navigating this way is much quicker than listening to a whole page, however the context provided by paragraphs and other narrative is lost and non-descriptive links become harder to understand. For downloadable links, we recommend that the file type and size of the file is also included in the link text to allow the user to make a decision whether or not to download the file. On the 'opac-shelves.pl?op=view&shelfnumber=148&sortfield=title’ page there is a non-descriptive link labelled ‘Download’, this issue is found on numerous pages tested." This patch addresses similar Download buttons, adding aria-labels and aria-has popups to the links.
Created attachment 151564 [details] [review] Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing
Created attachment 151565 [details] [review] Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing
Created attachment 151566 [details] [review] Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing
Created attachment 151567 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing
Created attachment 151597 [details] [review] Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 151598 [details] [review] Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 151599 [details] [review] Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org>
> Bug 33808: Add aria-labels in reports-toolbar.inc The label on this one, "Select format and download chart" is incorrect. It should be something like "Select format and download report results."
Created attachment 151617 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing
Thanks Owen, I've updated the patch as suggested :)
Created attachment 151621 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 153495 [details] [review] Bug 33808: Add aria-labels in opac-shelves.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 153496 [details] [review] Bug 33808: Add aria-labels in opac-basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 153497 [details] [review] Bug 33808: Add aria-labels in basket.tt This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 153498 [details] [review] Bug 33808: Add aria-labels in reports-toolbar.inc This patch adds an aria-label and an aria-haspopup to Download buttons identified as non-descriptive in accessibility testing Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x
Backported to 22.05.x for upcoming 22.05.16