|
Description
Matt Blenkinsop
2023-05-23 14:12:29 UTC
Created attachment 151568 [details] [review] Bug 33809: Facet "Show more/less" links don't identify what they are showing This patch addresses the Show more/less links in the side menu in opac-facets.inc. The links don't identify which facet they are linked to and this is confusing for screen readers. Created attachment 151569 [details] [review] Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear Created attachment 151576 [details] [review] Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear Created attachment 151606 [details] [review] Bug 33809: Facet "Show more/less" links don't identify what they are showing This patch addresses the Show more/less links in the side menu in opac-facets.inc. The links don't identify which facet they are linked to and this is confusing for screen readers. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 151607 [details] [review] Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 151925 [details] [review] Bug 33809: (follow-up) Grammar correction This is somewhat nitpicky but I think "Show fewer..." is more correct than "Show less..." for strings like "Show fewer authors." 'Generally, fewer is used when the number of things is counted ("fewer problems") whereas less is used when the number is measured ("less trouble" or "less time").' -- https://www.merriam-webster.com/words-at-play/fewer-vs-less It's not a strict rule but to my ear it sounds more correct. The brief "Show less" displayed on screen seems fine because the object feels indeterminate: "Show less information." Ahh I originally put "Show fewer..." in those strings but changed it as I thought it might get rejected for consistency with the "Show less" link. Completely agree with "Show fewer...", should've taken the gamble when I uploaded the patch! Created attachment 152050 [details] [review] Bug 33809: (follow-up) Grammar correction This is somewhat nitpicky but I think "Show fewer..." is more correct than "Show less..." for strings like "Show fewer authors." 'Generally, fewer is used when the number of things is counted ("fewer problems") whereas less is used when the number is measured ("less trouble" or "less time").' -- https://www.merriam-webster.com/words-at-play/fewer-vs-less It's not a strict rule but to my ear it sounds more correct. The brief "Show less" displayed on screen seems fine because the object feels indeterminate: "Show less information." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 153121 [details] [review] Bug 33809: Centralize duplicated code I am seeing items.title Please clarify? Do you mean you are seeing it in the label in the OPAC or just seeing it in the code? I've just checked the patch again and am seeing it correctly in the OPAC. In terms of why it is items (plural) in the code - for each result the title-actions-menu.inc is rendered to produce the action links. It takes a parameter of items and in this case that receives the value of SEARCH_RESULT which is the bib record. I'm not really sure why "items" is used as the parameter when it appears to be passing a bib record - maybe that's something to change in a new bug? Created attachment 157986 [details] [review] Bug 33809: Facet "Show more/less" links don't identify what they are showing This patch addresses the Show more/less links in the side menu in opac-facets.inc. The links don't identify which facet they are linked to and this is confusing for screen readers. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 157987 [details] [review] Bug 33809: Place hold and Add to cart links need better descriptions The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 157988 [details] [review] Bug 33809: (follow-up) Grammar correction This is somewhat nitpicky but I think "Show fewer..." is more correct than "Show less..." for strings like "Show fewer authors." 'Generally, fewer is used when the number of things is counted ("fewer problems") whereas less is used when the number is measured ("less trouble" or "less time").' -- https://www.merriam-webster.com/words-at-play/fewer-vs-less It's not a strict rule but to my ear it sounds more correct. The brief "Show less" displayed on screen seems fine because the object feels indeterminate: "Show less information." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 157989 [details] [review] Bug 33809: Centralize duplicated code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x I don't think there's anything to add or change in the manual for this. |