| Summary: | Accessibility: Lists button is not clearly identified | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
| Component: | OPAC | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement adds an aria-label to the Lists button in the OPAC masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button.
|
Version(s) released in: |
23.11.00,23.05.01,22.11.07
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 27496 | ||
| Attachments: |
Bug 33813: Masthead lists button requires an aria-label
Bug 33813: Masthead lists button requires an aria-label Bug 33813: Masthead lists button requires an aria-label Bug 33813: Masthead lists button requires an aria-label |
||
|
Description
Matt Blenkinsop
2023-05-23 16:26:28 UTC
Created attachment 151595 [details] [review] Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. Should we be concerned about using the phrase "Click to..." ? That label wouldn't be acceptable if it were part of a text link. (In reply to Owen Leonard from comment #2) > Should we be concerned about using the phrase "Click to..." ? That label > wouldn't be acceptable if it were part of a text link. Yes, "Click to..." doesn't provide anything useful for assistive technologies. I think something like "Show dropdown with detailed list information" would be better in this case. (In reply to Lucas Gass from comment #3) > I think something like "Show dropdown with detailed list information" would > be better in this case. +1 Created attachment 151616 [details] [review] Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. Thanks for the input everyone, I've updated the patch accordingly Created attachment 151620 [details] [review] Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. Signed-off-by: David Nind <david@davidnind.com> Created attachment 151631 [details] [review] Bug 33813: Masthead lists button requires an aria-label This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Can this be pushed to 23.05? It landed in the queue for 22.11.07 but doesn't appear to be in stable Ignore that - was looking at the wrong branch! Updating to 'Pushed to stable' and adding released version before oldstable rmaint activity Nice work everyone! Pushed to oldstable for 22.11.x |